Skip to content

Add egglog to the CI so we stop breaking it #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add egglog to the CI so we stop breaking it #1420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7484341
Add egglog to the CI so we stop breaking it
pavpanchekha Nov 4, 2025
0fecded
Oh, we already had a rule, it just didn't error
pavpanchekha Nov 4, 2025
42b4ba9
Comments
pavpanchekha Nov 4, 2025
9f48ffd
Remove the crazy timeout, egglog is reasonably fast now
pavpanchekha Nov 4, 2025
8b52224
Specialize to egglog
pavpanchekha Nov 4, 2025
b170d65
Merge branch 'main' into ci-egglog
pavpanchekha Nov 4, 2025
7d7019b
Woops
pavpanchekha Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,10 @@ jobs:
racket -l herbie report --threads yes --seed 1 bench/hamming/rearrangement.fpcore graphs0
racket -l herbie report --threads yes --seed 1 bench/hamming/rearrangement.fpcore graphs1
racket infra/diff.rkt graphs0 graphs1

# Test egglog mode
- name: "Run Herbie with egglog"
run: racket -l herbie report --timeout 600 +o generate:egglog --seed 1 bench/hamming/trigonometry.fpcore graphs2
run: racket -y infra/ci.rkt --egglog --seed 0 bench/hamming/trigonometry.fpcore

# Test the egg-herbie Rust code
- run: cd egg-herbie && cargo clippy --tests
Expand Down
1 change: 1 addition & 0 deletions infra/ci.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
(define given-seed (read (open-input-string rs)))
(when given-seed
(set-seed! given-seed))]
[("--egglog") "Switch to the egglog backend" (enable-flag! 'generate 'egglog)]
[("--platform") platform "Which platform to use for tests" (*platform-name* platform)]
[("--precision") prec "Which precision to use for tests" (*precision* (string->symbol prec))]
[("--num-iters")
Expand Down
Loading