-
Notifications
You must be signed in to change notification settings - Fork 1
Add async API calls. #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async API calls. #135
Conversation
|
Awesome! I think the process for doing this will be
I'll use this PR as the issue for tracking this work |
|
Let me know how I can help. |
|
Just thought of a bug/error in this code. |
|
Remaining steps:
|
|
I'll test against the updated server today, won't point to the server or merge yet |
|
No progress due to OOPSLA |
|
No progress this week due to generals, but I should have some time to work on this on Thursday/Friday. I'll test against the server now that it's updated and switch local Odyssey to point to the server until binaries are updated. |
4d802e2 to
1d5501c
Compare
|
Worked on adding a fallback check if the async API's don't exist. Getting some weird errors with errors not being caught. |
|
I'm merging this branch now, tested locally and it works. |
This PR switches Odyessy to using the new Async for the API's that are available to be called that way. I don't know if that is what we want to do but it did make testing that the API's were working correctly with this new calling convention when testing locally.
This PR does rely on this Herbie PR to enable CORS for the
checkstatusendpoint. This has been merged with main now.