Adding a separate function of rival-analyze-with-hints
#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavpanchekha
approved these changes
Jul 4, 2025
Contributor
pavpanchekha
left a comment
pavpanchekha
left a comment
There was a problem hiding this comment.
Can you make the matching PR to Herbie so we can merge both in short succession? Because this is going to break Herbie main, right?
eval/main.rkt
Outdated
Comment on lines
95
to
102
|
|
||
| (define (rival-analyze machine rect) | ||
| ; Load arguments | ||
| (rival-machine-load machine rect) | ||
| (define-values (good? done? bad? stuck? fvec) | ||
| (parameterize ([*sampling-iteration* 0]) | ||
| (rival-machine-full machine (rival-machine-default-hint machine)))) | ||
| (ival (or bad? stuck?) (not good?))) |
Contributor
There was a problem hiding this comment.
This is fine but since it isn't perf sensitive why not just call rival-analyze-with-hints and discard the hints? Would avoid the copy-and-paste.
Contributor
Author
There was a problem hiding this comment.
Done, just made a Herbie's PR as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, it has been noticed that older versions of Herbie are not compatible with new Rival's changes regarding
analyzewithhints.This PR provides an old-style
rival-analyzefor older versions of Herbie in order to being able to use them.