Several missing tricks entries; hope this is faster #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obround
approved these changes
Oct 24, 2025
Contributor
Author
|
A lot less impact (weirdly) than I thought but 🤷. One thing I'd really love to do at some point is figure out how far we are from "optimal" precision assignment, not super sure how we'd do the experiment but super attractive if we can figure it out because I'm sure it can be improved very easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically fixes an oversight in #132, wherein we started using mutable functions in the compiler but are not switching on them in the tricks. While doing that I noticed that we never had a tricks function for
neg! Honestly we need to fix this and stop making this kind of mistakes; I might do this in this PR or another one, but definitely a big oversight.