Skip to content

Conversation

@pavpanchekha
Copy link
Contributor

Both are minor bugs, one causes explain to break, the other causes eval to print small numbers wrong (1e-100 prints as 0).

@pavpanchekha pavpanchekha requested a review from obround October 27, 2025 04:24
Copy link
Contributor

@obround obround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's another REPL bug where it prints a bunch of blank space when explain is called on certain functions that I need to make PRs for. I've been drowning in some work, but I'll polish and make that PR soon, hopefully.

@pavpanchekha
Copy link
Contributor Author

Oh, yeah, that is not necessarily a bug, if you have an expression like (* 3 (+ 1 2)) then Rival won't execute that every time you do rival-apply, it'll do that once and reuse the result across different inputs. That's why the rows show up empty. It's most common with constants like 1 or (PI).

@obround
Copy link
Contributor

obround commented Oct 27, 2025

Ah, I see, sounds good!

@pavpanchekha pavpanchekha merged commit ab743e1 into main Oct 27, 2025
1 check passed
@pavpanchekha pavpanchekha deleted the fix-repl branch October 27, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants