feat: always log targets #2030
Open
feat: always log targets #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jounathaen
approved these changes
Oct 29, 2025
Member
jounathaen
left a comment
jounathaen
left a comment
There was a problem hiding this comment.
I think it is fine. The double space between INFO and the target bugs me a little, but that's something for another PR 😉
Contributor
sarahspberrypi
left a comment
sarahspberrypi
left a comment
There was a problem hiding this comment.
I'm not sure if getting rid of this feature by making it the default is the way to go here. For debugging purposes, I see the appeal but for "normal use", I don't see any benefit of showing these targets.
Member
Author
I introduced that yesterday in #2021 (0d620cf). The reason for that is to align the different log level names ( Excerpt with `LOG_LEVEL=trace`Stefan also likes the feature and is okay with always displaying the target (compare with |
Contributor
I'm still not convinced, it adds unnecessary cluttering imo. Similarly, you only ever call |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Results
| Benchmark | Current: a6ee871 | Previous: b9e34fd | Performance Ratio |
|---|---|---|---|
| startup_benchmark Build Time | 113.33 s |
110.50 s |
1.03 |
| startup_benchmark File Size | 0.91 MB |
0.91 MB |
1.00 |
| Startup Time - 1 core | 0.96 s (±0.03 s) |
0.91 s (±0.04 s) |
1.06 |
| Startup Time - 2 cores | 0.97 s (±0.04 s) |
0.92 s (±0.04 s) |
1.05 |
| Startup Time - 4 cores | 0.98 s (±0.02 s) |
0.92 s (±0.04 s) |
1.07 |
| multithreaded_benchmark Build Time | 112.62 s |
110.26 s |
1.02 |
| multithreaded_benchmark File Size | 0.97 MB |
1.02 MB |
0.95 |
| Multithreaded Pi Efficiency - 2 Threads | 85.10 % (±8.53 %) |
88.88 % (±7.88 %) |
0.96 |
| Multithreaded Pi Efficiency - 4 Threads | 42.34 % (±3.86 %) |
44.09 % (±4.43 %) |
0.96 |
| Multithreaded Pi Efficiency - 8 Threads | 24.74 % (±1.92 %) |
25.18 % (±2.08 %) |
0.98 |
| micro_benchmarks Build Time | 271.73 s |
270.98 s |
1.00 |
| micro_benchmarks File Size | 0.97 MB |
1.02 MB |
0.95 |
| Scheduling time - 1 thread | 150.69 ticks (±21.02 ticks) |
153.15 ticks (±22.52 ticks) |
0.98 |
| Scheduling time - 2 threads | 89.84 ticks (±20.19 ticks) |
89.47 ticks (±17.51 ticks) |
1.00 |
| Micro - Time for syscall (getpid) | 8.08 ticks (±4.50 ticks) |
10.74 ticks (±5.67 ticks) |
0.75 |
| Memcpy speed - (built_in) block size 4096 | 62515.09 MByte/s (±44139.97 MByte/s) |
59208.17 MByte/s (±42422.24 MByte/s) |
1.06 |
| Memcpy speed - (built_in) block size 1048576 | 15236.82 MByte/s (±12306.67 MByte/s) |
15604.80 MByte/s (±12636.68 MByte/s) |
0.98 |
| Memcpy speed - (built_in) block size 16777216 | 10662.93 MByte/s (±8546.99 MByte/s) |
11487.12 MByte/s (±9319.97 MByte/s) |
0.93 |
| Memset speed - (built_in) block size 4096 | 62475.27 MByte/s (±44107.06 MByte/s) |
59588.60 MByte/s (±42746.95 MByte/s) |
1.05 |
| Memset speed - (built_in) block size 1048576 | 15633.37 MByte/s (±12581.60 MByte/s) |
16061.98 MByte/s (±12923.91 MByte/s) |
0.97 |
| Memset speed - (built_in) block size 16777216 | 10931.83 MByte/s (±8716.15 MByte/s) |
11848.78 MByte/s (±9579.64 MByte/s) |
0.92 |
| Memcpy speed - (rust) block size 4096 | 55679.43 MByte/s (±40294.27 MByte/s) |
57174.91 MByte/s (±41348.10 MByte/s) |
0.97 |
| Memcpy speed - (rust) block size 1048576 | 15613.43 MByte/s (±12596.28 MByte/s) |
15863.50 MByte/s (±12841.95 MByte/s) |
0.98 |
| Memcpy speed - (rust) block size 16777216 | 10945.10 MByte/s (±8839.93 MByte/s) |
11291.00 MByte/s (±9142.92 MByte/s) |
0.97 |
| Memset speed - (rust) block size 4096 | 56034.35 MByte/s (±40504.61 MByte/s) |
57859.11 MByte/s (±41771.72 MByte/s) |
0.97 |
| Memset speed - (rust) block size 1048576 | 16002.92 MByte/s (±12820.29 MByte/s) |
16241.25 MByte/s (±13076.73 MByte/s) |
0.99 |
| Memset speed - (rust) block size 16777216 | 11152.99 MByte/s (±8950.58 MByte/s) |
11628.25 MByte/s (±9377.45 MByte/s) |
0.96 |
| alloc_benchmarks Build Time | 269.03 s |
267.07 s |
1.01 |
| alloc_benchmarks File Size | 0.98 MB |
0.97 MB |
1.00 |
| Allocations - Allocation success | 100.00 % |
100.00 % |
1 |
| Allocations - Deallocation success | 100.00 % |
100.00 % |
1 |
| Allocations - Pre-fail Allocations | 100.00 % |
100.00 % |
1 |
| Allocations - Average Allocation time | 17430.83 Ticks (±718.39 Ticks) |
17736.97 Ticks (±1105.55 Ticks) |
0.98 |
| Allocations - Average Allocation time (no fail) | 17430.83 Ticks (±718.39 Ticks) |
17736.97 Ticks (±1105.55 Ticks) |
0.98 |
| Allocations - Average Deallocation time | 2057.50 Ticks (±369.88 Ticks) |
2231.85 Ticks (±637.37 Ticks) |
0.92 |
| mutex_benchmark Build Time | 266.33 s |
267.03 s |
1.00 |
| mutex_benchmark File Size | 0.98 MB |
1.02 MB |
0.95 |
| Mutex Stress Test Average Time per Iteration - 1 Threads | 33.08 ns (±3.02 ns) |
33.16 ns (±3.05 ns) |
1.00 |
| Mutex Stress Test Average Time per Iteration - 2 Threads | 27.36 ns (±3.06 ns) |
29.18 ns (±3.00 ns) |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2021 to make target logging unconditional and removes the corresponding feature.
Before
After