using write_volatile to guarantee that the data is written to the I/O device #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, yes. This partly fixes #199. The problem is known since May, when we disabled I am still waiting on rust-osdev/volatile#22 to do an rework on all affected drivers. In the meantime, this is a good step in the right direction. 👍 bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 1, 2021
303: using write_volatile to guarantee that the data is written to the I/O device r=mkroening a=stlankes `@simonschoening` reports that the current implementation doesn't work on RISC-V. By using `write_volatile` we should get a more platform independent solution. Co-authored-by: Stefan Lankes <[email protected]>
mkroening
approved these changes
Dec 1, 2021
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Dec 1, 2021
303: using write_volatile to guarantee that the data is written to the I/O device r=mkroening a=stlankes `@simonschoening` reports that the current implementation doesn't work on RISC-V. By using `write_volatile` we should get a more platform independent solution. 304: Tests: Add test_thread_local r=mkroening a=mkroening See * hermit-os/hermit-rs#170 Co-authored-by: Stefan Lankes <[email protected]> Co-authored-by: Martin Kröning <[email protected]>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Dec 2, 2021
303: using write_volatile to guarantee that the data is written to the I/O device r=mkroening a=stlankes `@simonschoening` reports that the current implementation doesn't work on RISC-V. By using `write_volatile` we should get a more platform independent solution. Co-authored-by: Stefan Lankes <[email protected]>
|
Timed out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Dec 2, 2021
303: using write_volatile to guarantee that the data is written to the I/O device r=mkroening a=stlankes `@simonschoening` reports that the current implementation doesn't work on RISC-V. By using `write_volatile` we should get a more platform independent solution. Co-authored-by: Stefan Lankes <[email protected]>
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simonschoening reports that the current implementation doesn't work on RISC-V. By using
write_volatilewe should get a more platform independent solution.