-
Notifications
You must be signed in to change notification settings - Fork 14
Added socket.disconnect() #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/test_socket.lua
Outdated
| local socket = client.create_socket() | ||
|
|
||
| socket.disconnect() | ||
| assert_true(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assert will always pass, is this intended? Isn't there a better way to assert if the sockets was indeed disconnected?
Like:
assert_nil(socket.connection)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Let me take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DannyIsYog I've updated the test with a better assert. Could you please take another look?
DannyIsYog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Thanks. @DannyIsYog what does is the correct release process for this repository when there are external collaborators such as myself? I am able to create a new release, but I also need to update the changelog to assign the unreleased changes to a release prior to actually making the release itself. Do I first create a separate PR with the changelog update and then do the release? |
Added function to disconnect a previously connected socket:
Fix #84