Skip to content

Conversation

@2xhamzeh
Copy link

@2xhamzeh 2xhamzeh commented Oct 18, 2025

Updated config.ld to use the same docs file in the future instead of doc or having to specifiy it. Added module declaration to nakama/socket.lua so the doc file can be generated. Changed module name in nakama/session.lua to match file structure nakama.util.session => nakama.session Regenerated the docs using ldoc

Closes #88

Updated config.ld to use the same docs file in the future instead of doc or having to specifiy it.
Added module declaration to nakama/socket.lua so the doc file can be generated.
Changed module name in nakama/session.lua to match file structure nakama.util.session => nakama.session
Regenerated the docs using ldoc
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2025

CLA assistant check
All committers have signed the CLA.

@2xhamzeh
Copy link
Author

I think my code editor reformatted the files session.lua and socket.lua when saving, I'll try to avoid doing that in the future. Also this is the first time I contribute to an open source project so if there is any feedback please let me know :)

@britzl britzl requested a review from DannyIsYog October 22, 2025 17:02
Create and check sessions.
@module nakama.util.session
@module nakama.session

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to remove the .util?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The session module (session.lua) is within the nakama directory, so when requiring it you'd do require "nakama.session" and not "nakama.util.session", so I thought the docs should also have the correct path.

@DannyIsYog DannyIsYog self-requested a review October 26, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs not up to date

3 participants