rpcHttpKey function uses POST now #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Hey @delasource we cannot modify the existing rpcHttpKey from GET to POST because it would subtly break users' server runtime functions that are expecting query parameters. Would introducing a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #162 and #133
(and also probably heroiclabs/nakama#400 )
even though you could argue that you throw the payload part of a GET request away by intention, using POST for server-to-server calls is even a security bonus, as the possibility to sniff query params gets eliminated.
Also nowhere in the docs it is mentioned, that "input" is not a thing in these rpcHttpKey-calls. This PR fixes that and makes the "input" param actually behave the same way, that session-authorized rpc's do.