migrate(W-14169233): spaces: Upgrade drains:set #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
LGTM. Approving, although it might be worth a chat with @dsouza-anush to see if we should move this command under the space topic or perhaps renamed some other way to reduce confusion with add, which acts on an app.. as suggested in #2433
k80bowman
added a commit
that referenced
this pull request
Jul 16, 2024
…nd move them to the cli package (#2927) * refactor(container): add type to addons in `addons:wait` (#2655) * Type the addon for filtering. * Update to explicitly type addonsToWaitFor * Use temporary type instead of ignoring type error. * refactor(W-14142188): addons-v5: Upgrade addons:upgrade (#2653) * refactor(W-14142188): addons-v5: Upgrade addons:upgrade * Added addons:downgrade alias * Removed addons-v5 since no more commands exist there * refactor(container-registry-v5): Move 'container:logout' to CLI (#2648) * Refactor stub for clarity * Move 'container:logout' to CLI, OClif & TS * Adding missed unit tests for migrated DockerHelper lib functions * Fix usage of any when catching error Co-authored-by: Justin Wilaby <[email protected]> --------- Co-authored-by: Justin Wilaby <[email protected]> * refactor(apps-v5): migrate releases:info to oclif and remove apps-v5 package (#2654) * refactor: initial refactor for releases:info command * refactor: add logic for getting user email * refactor: fix shell-escape import * refactor: complete initial command migration * refactor: cleanup command * refactor: migrate tests for releases:info * refactor: remove v5 releases:info command and test files * refactor: remove the apps-v5 package and plugin imports * chore: update yarn.lock * refactor: add --remote flag to all releases commands * fix: move call for config and update userEmail variable and update test * fix: remove apps-v5 again after rebase * refactor(container-registry-v5): move container:rm to CLI & upgrade to oclif (#2656) * Convert container:rm to oclif * Convert rm test to test oclif version * Remove rm from container-v5 * Update test output check * Include docker variant header and expect it in test * refactor(container-registry-v5): move container:run to CLI & upgrade to oclif (#2657) * Convert container:run to oclif * Convert container run test to oclif * Fix test expectation * Update text output expectation * Change runImage function interface slightly, add docker_helper tests. * Add basic type for map function * Fix runImage so it always passes the right things * Fix spaces convention * Update test description * Fix location of container run test * Add fixtures to new testing area * Fix fixture file location * Update format of test expect * Fix os-specific pathing issue * Update packages/cli/test/unit/commands/container/run.unit.test.ts Co-authored-by: Justin Wilaby <[email protected]> * Add pullImage test * Clean up line breaks --------- Co-authored-by: Justin Wilaby <[email protected]> * chore(cli): Add local test option (#2661) * Add test:local that allows .only * Make test script naming consistent * Fix test:local * refactor: migrate access:index to oclif/core (#2658) * refactor: initial access:index command migration * refactor: initial linting fixes and add types * refactor: migrate isTeamApp and getOwner util functions * refactor: reformat table construction * refactor: refactor collaborators array functions * refactor: more typing fixes * refactor: migrate access tests, stubs, and update table format * refactor: rename utils file * refactor: remove orgs-v5 access command and tests. Add integration test * refactor: remove integration test script from orgs-v5 * refactor(orgs-v5): move access:update to CLI & upgrade to oclif (#2660) * Convert orgs:access:update to oclif * Remove v5 access update command * Fix error expectation * Remove deprecated privileges alias, use stripansi * refactor(orgs-v5): move teams to CLI & upgrade to oclif (#2662) * Convert teams index command to oclif * Convert teams index test * Remove .only * Fix linting issue * Use heredoc to make indentation nicer * refactor: migrate members/index to oclif/core (#2665) * refactor: initial migration and typing for members/index * refactor: refactor lib functions * refactor: additional typing fixes * refactor: refactor to use ux.table * refactor: migrate members:index tests and utils function fix * refactor: refactor to use required flag for team * refactor: do not show status column when there are no pending invites * refactor: remove v5 files and references * refactor(certs-v5): move certs to CLI & upgrade to oclif (#2664) * Convert certs:index and some lib functions * Fix displaytable bugs, add unit test for certs:index. * remove .only * Replace any with more specific types * use heredoc for improved clarity * Have explicit types when sorting * refactor: delete deprecated orgs:default command (#2671) * refactor(container-registry-v5): Move 'container:push' to CLI (#2663) * Update glob package version for CLI * Fix eslint warning * Moving tests for 'container:pull' to the right folder * Fixing path references on moved test file * Move command 'container:push' to CLI, OClif Core & TS * Convert unit tests for 'container:push' to CLI, OClif Core & TS * Fixing duplicated 'Error:' string on error outputs * refactor: migrate members:set to oclif/core (#2674) * refactor: migrate members:set command to oclif/core * refactor: migrate members:set tests * refactor: remove orgs-v5 members:set files * refactor: migrate orgs/index to oclif/core (#2670) * refactor: refactor orgs command and utils * refactor: migrate orgs tests * refactor: delete orgs/index and test from orgs-v5 * refactor: update class name * refactor: migrate orgs:open to oclif/core (#2672) * refactor: migrate ogs:open command to oclif/core * refactor: add opening message and move open action to separate function * refactor: migrate orgs:open tests to oclif * refactor: remove v-5 orgs:open command and test files * refactor: update class name * refactor: migrate access:remove to oclif/core (#2676) * refactor: initial migration of access:remove * refactor: initial test refactor * refactor: test fix and update class name * refactor: remove orgs-v5 access:remove files * refactor: remove 'use strict' from stubs/delete * refactor: migrate members:remove to oclif/core (#2678) * refactor: migrate members:remove command to oclif/core * refactor: migrate tests for members:remove * fix: remove commented out code in test * refactor: remove members:remove command and test files from orgs-v5 * refactor: migrate members:add to oclif/core (#2673) * refactor: migrate members:add command and utils to oclif/core * refactor: refactor members:add tests and test utils * refactor: remove orgs-v5 members:add files * fix: update array.find to array.some and change require to import * refactor(certs-v5): move certs:auto:refresh to CLI & upgrade to oclif (#2668) * Convert acm refresh command to oclif * Fix spacing lint issue * Remove v5 versions of certs auto refresh * refactor(certs-v5): move certs:auto:disable to CLI & upgrade to oclif (#2667) * Convert certs auto disable to oclif * Fix test and apply tsheredoc to clean up output * Make confirm flag hidden * refactor(container-registry-v5): Move 'certs:info' to CLI (#2669) * Convert certs:info to oclif * Convert endpoint stubs to types, convert shared_sni test * Fix testing data * Fix testing output for shared tests * Fix shared tests * Fix spelling typo * Change heredoc indents * Rework cert stub data * Update commands-output to reflect change Reintroduce removing spaces Update commands output to include fig spec for now * refactor: migrate access:add to oclif/core (#2683) * refactor: migrate access:add to oclif/core * refactor: migrate tests for access:add * refactor: remove commands:access files from orgs-v5 * refactor: remove access:index file from orgs-v5 (leftover from previous PR) * refactor: migrate command examples and flag description * fix: remove semi-colon * refactor(certs-v5): Move command 'certs:auto:enable' to CLI (#2687) * Move command 'certs:auto:enable' to CLI * Removing unused lib file (migration completed) * Restoring lib file (migration was completed, but still referenced from another command) * Fixing expected outputs in tests. * refactor: migrate container:release to oclif/core (#2659) * refactor: migrate container:release to oclif * refactor: migrate streamer helper and tests to typescript * refactor: migrate container:release tests to typescript * refactor: typescript and eslint fixes * refactor: fix first unit test * refactor: fix call to registry.heroku.com and reformat tests * refactor: add oclif static vars * refactor: remove container:release v5 command and related files * refactor: add authorization for docker registry call and rename class * refactor: remove the container-registry-v5 package and import * update yarn.lock * migrate(W-14161871): migrate certs:add to typescript (#2691) * refactor: migrate apps:join to oclif/core (#2689) * refactor: migrate apps:join command to oclif/core * refactor: initial test conversion * refactor: migrate stubs/post and update apps:join tests * refactor: remove v5 apps:join files and tests * refactor: update apps:join test structure * refactor: update types and test helper function * refactor: remove unnecessary params from test helper function * refactor: replace param in test helper function * migrate(W-14162583): Migrate orgs:apps:leave (#2699) * refactor(redis-v5): Move 'redis:info' to CLI (#2705) * Convert redis info to oclif * Add test for redis info command * Add index as alias for redis:info, update tests * Fix whitespace test issue * Go back to duplicating code * Move test to right directory, update test to do both info and index * try alias with just redis * fix dumb whitespace issue again * remove .only * Jw/certs v5/migrate generate command (#2707) * certs-v5(W-14161962): migrate certs:generate * Added remotes flag * Removed commented code * refactor: migrate apps:lock command to oclif/core * refactor: migrate unit tests for apps:lock * refactor: remove unit test and commands listing for apps:lock * refactor: add topic to lock command * refactor: add lock alias * refactor: remove semi-colons * WIP fix acceptance test * Fix acceptance test & fix test spelling error * refactor: complete migration of apps:unlock * refactor: migrate apps:unlock test * refactor: add alias for apps:unlock command * refactor: delete orgs-v5 version of apps:unlock and tests * fix: remove import of afterEach * fix: add space to fix linting error * refactor: use ux.error in unlock.ts Co-authored-by: Santiago Bosio <[email protected]> * refactor: use CLIError type in unlock.unit.test.ts Co-authored-by: Santiago Bosio <[email protected]> * fix: add import of CLIError to tests * refactor(redis-v5): Move 'redis:maxmemory' to CLI (#2710) * Conver maxmemory to oclif * Convert maxmemory unit test, remove old maxmemory from redis index * Add shared tests * Fix config_vars bug in api, add typing to config response, fix description bug for maxmemory * Remove copy and paste error * Fix patch call and use type * Update commands output * Update mocha, change timeout (#2715) * refactor(redis-v5): Moving command 'redis:credentials' to CLI (#2712) * Moving command 'redis:credentials' to CLI * Rebased onto prerelease branch and resolved conflicts. * Removing duplicated unit test file. * Fixing failing import after removal of the duplicated file. * refactor(redis-v5): Move 'redis:upgrade' to CLI (#2719) * Convert redis upgrade to oclif * Fix tests * Change to using id, update tests * chore(W-15263489): improve unit test performance (#2716) (#2721) * Move command 'redis:keyspace-notifications' to CLI (#2717) * refactor(redis-v5): Move 'redis:stats-reset' to CLI (#2722) * Convert redis stats reset to oclif * remove .only * remove stats-reset from old redis index * Fix spelling error * Jw/redis v5/migrate redis cli (#2718) * redis-v5(W-14165217): migrate redis:cli * Completed unit test conversion * removed old command * reconciled existing migrated utils * Move 'redis:maintenance' to CLI (#2724) * refactor(certs-v5): Move command `certs:auto` (index) to CLI (#2695) * Introducing fixed interfaces for SniEndpoint and Domain * Need to bring things from my other PR until it's merged * Migrated certs:auto (index) command and tests * Removing old command files * Refactoring support libs to use the new interfaces * Removed superfluous lib file * Refactored previous certs commands to align with new interfaces * Refactored previous certs unit tests to align with new interfaces * Merging changes from upstream prerelease branch * Addressing PR feedback and rebasing * Rebasing onto prerelease branch (again) and fixing merge conflicts. * refactor(redis-v5): Move 'redis:timeout' to oclif (#2725) * Convert redis timeout to oclif * Fix description * Try to make smoke test happy * refactor(redis-v5): Move redis:promote command to CLI (#2726) * refactor(redis-v5): Move redis:promite command to CLI * Fixes afer branch update * Update packages/cli/src/commands/redis/promote.ts Co-authored-by: Santiago Bosio <[email protected]> * Addressed PR comments * Revert "Addressed PR comments" This reverts commit 855efff. --------- Co-authored-by: Santiago Bosio <[email protected]> * refactor(pg-v5): Move 'pg:backups:url' to oclif (#2727) * Convert pg backup url to oclif * Remove from index * Fix hostname * Remove commented out test * Change color for app output * Rename backups api * Move command 'certs:remove' to CLI (#2731) * refactor(pg-v5): Move 'pg:backups:info' to oclif (#2733) * Convert pg backups info to oclif * Comment out test that relies on old pg-v5 info command * Fix hostname issue, clean up getBackup function * change sortby to import * Clean up info functions, remove old javascript info command * migrate(W-14170373): Upgrade pg:backups:delete (#2734) * migrate(W-14170373): Upgrade * migrate(W-14170373): Upgrade pg:backups:delete * Fix timing and other issues with dashboard tests (#2739) * refactor(pg-v5): Move 'pg:backups:schedules` to oclif (#2737) * Convert pg backups schedules to oclif * remove .only * Fix tests, update app name logging * Update test check to work on different platforms * Remove unused stripansi * refactor(pg-v5): Move 'pg:backups:download` to oclif (#2735) * Convert pg backups download to oclif * remove .only * Remove old download test * Switch to use fs instead of mkdirp * Fix api call for public-url * Add remote flag * Update packages/cli/src/commands/pg/backups/download.ts Co-authored-by: Santiago Bosio <[email protected]> --------- Co-authored-by: Santiago Bosio <[email protected]> * refactor(redis-v5): Move `redis:wait` command to CLI (#2728) * Migrated 'wait' command * Migrated unit tests for command 'redis:wait' * Removing old command files * refactor(pg-v5): Move pg:backups:schedule to oclif (#2745) * Convert pg backup schedule to oclif * Convert pg back schedule test * Fix tests checking output * Warn when defaulting to UTC * Only warn if user supplied a timezone * Fix warning message expectation * Update packages/cli/src/lib/pg/fetcher.ts Co-authored-by: Justin Wilaby <[email protected]> * Update packages/cli/src/commands/pg/backups/schedule.ts Co-authored-by: Justin Wilaby <[email protected]> * Refactor to use existing Attachment type --------- Co-authored-by: Justin Wilaby <[email protected]> * migrate(W-14170389): Upgrade 'pg:backups' index (#2740) * migrate(W-14170389): Upgrade index * removed old sources * Updated unit test to use heredoc for readability * refactor(certs-v5): Move command `certs:update` to CLI (#2742) * Migrated command 'certs:update' to CLI * Migrating command tests. * Removing old command and test files. * Removing shared libs and test files. * Fix output for failing test. * Suggested changes in PR feedback. * migrate(W-14170470): Upgrade pg:credentials:create (#2746) * migrate(W-14170470): Upgrade pg:credentials:create * Added remote flag * fixed type from migration script * resolved conflicts after rebase * Added example command to description * refactor(pg-v5): Move command `pg:backups:unschedule` to oclif (#2749) * Convert unschedule to oclif * Fix test by stripping ansi * Update to resolve changes in fetcher lib * Update colors in output for app * Fix test output checking * refactor(pg-v5): Move command `pg:credentials:destroy` to oclif (#2751) * Convert pg credentials destroy to oclif * Use default destructive action messaging * Move destroy test to right place * Fixing acceptance test for 'heroku commands' * migrate(W-14170430): Upgrade pg:backups:restore (#2752) * migrate(W-14170430): Upgrade pg:backups:restore * Small changes based on PR feedback * Convert pg repair default to oclif (#2753) * migrate(W-14179700): pg-v5: Upgrade pg:links:create (#2758) * migrate(W-14179700): pg-v5: Upgrade pg:links:create * Update packages/cli/src/commands/pg/links/create.ts Co-authored-by: Santiago Bosio <[email protected]> * Moved help to description --------- Co-authored-by: Santiago Bosio <[email protected]> * refactor(pg-v5): Move command `pg:credentials:url` to oclif (#2757) * Convert credentials url to oclif * remove .only * Fix URL construction and API call with basic auth, fix tests. * Update tests to use fixtures * Update packages/cli/src/commands/pg/credentials/url.ts Co-authored-by: Santiago Bosio <[email protected]> * Update packages/cli/src/commands/pg/credentials/url.ts Co-authored-by: Santiago Bosio <[email protected]> * Use ux.error * Update packages/cli/src/commands/pg/credentials/url.ts Co-authored-by: Santiago Bosio <[email protected]> --------- Co-authored-by: Santiago Bosio <[email protected]> * refactor(pg-v5): Move command `pg:maintenance` to oclif (#2759) * Convert pg:maintenance to oclif * use ux.error * Update packages/cli/src/commands/pg/maintenance/index.ts Co-authored-by: Santiago Bosio <[email protected]> * Update packages/cli/src/commands/pg/maintenance/index.ts Co-authored-by: Santiago Bosio <[email protected]> --------- Co-authored-by: Santiago Bosio <[email protected]> * refactor(pg-v5): Move command pg:maintenance:run to oclif (#2760) * Convert pg:maintenance:run to oclif * Use ux.error * Update packages/cli/src/commands/pg/maintenance/run.ts Co-authored-by: Santiago Bosio <[email protected]> --------- Co-authored-by: Santiago Bosio <[email protected]> * backfill missing remote flag options (#2764) * Add missing remote flag to converted commands * Fix missing , * Fix typos * Jw/merge main into prerelease (#2769) * chore(deps): bump semver from 5.6.0 to 7.6.0 (#2619) Bumps [semver](https://github.com/npm/node-semver) from 5.6.0 to 7.6.0. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v5.6.0...v7.6.0) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump standard from 12.0.1 to 17.1.0 (#2701) Bumps [standard](https://github.com/standard/standard) from 12.0.1 to 17.1.0. - [Release notes](https://github.com/standard/standard/releases) - [Changelog](https://github.com/standard/standard/blob/master/CHANGELOG.md) - [Commits](standard/standard@v12.0.1...v17.1.0) --- updated-dependencies: - dependency-name: standard dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Wilaby <[email protected]> * chore(deps): bump inquirer and @types/inquirer (#2766) * chore(deps): bump inquirer and @types/inquirer Bumps [inquirer](https://github.com/SBoudrias/Inquirer.js) and [@types/inquirer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/inquirer). These dependencies needed to be updated together. Updates `inquirer` from 6.2.2 to 9.2.17 - [Release notes](https://github.com/SBoudrias/Inquirer.js/releases) - [Commits](https://github.com/SBoudrias/Inquirer.js/compare/[email protected]@9.2.17) Updates `@types/inquirer` from 7.3.0 to 9.0.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/inquirer) --- updated-dependencies: - dependency-name: inquirer dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/inquirer" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Changed inquirer to latest known commonjs compatible version --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Wilaby <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * pg-v5: Upgrade pg:credentials:rotate (#2756) * migrate(W-14179649): pg-v5: Upgrade pg:credentials:rotate * Updates based on PR feedback * Added the exclusive config for the 'all' flag * refactor(pg-v5): Move command pg:maintenance:window to oclif (#2762) * Convert pg:maintenance:window to oclif * Use ux.error instead * remove .only * refactor(pg-v5): Move command pg:links to oclif (#2770) * Convert pg:links to oclif * Fix line break spacing * refactor(pg-v5): Move command pg:links:destroy to oclif (#2763) * Convert pg:links:destroy to oclif * Add remote flag * require both db and link * Move command 'pg:backups:capture' to CLI * Remove '.only' and flag '--snapshot' * migrate(W-14179828): pg-v5: Upgrade pg:settings:auto-explain (#2773) * Move command 'pg:settings:auto-explain:log-analyze' to CLI * refactor(pg-v5): Move command pg:settings:auto-explain:log-buffers to oclif (#2775) * Convert auto explain log buffers to oclif * Fix whitespace * Fix test data * Update with latest setter changes * refactor(pg-v5): Move command pg:settings:auto-explain:log-min-duration to oclif (#2776) * Convert log-min-duration to oclif * remove .only * Fix settingKey * undo deletion of log_min_duration_statement tests * Removing commented static property * Fixing default add-on resolution * Renaming types to align with previous naming scheme. * Refactoring previously migrated settings commands * Move 'pg:settings:auto-explain:log-triggers' to CLI * migrate(W-14179873): pg-v5: Upgrade pg:settings:auto-explain:log-verbose (#2780) * migrate(W-14179873): pg-v5: Upgrade pg:settings:auto-explain:log-verbose * Updated paths after rebase * Move command 'pg:settings' (index) to CLI * Removing test from shared settings test. * Forgot to remove .only again * refactor: migrate apps:transfer to oclif/core (#2767) * refactor: initial migration of apps:transfer to oclif/core * refactor: move access utils since they are used by apps command * refactor: add isValidEmail to teamUtils * refactor: migrate AppTransfer lib class * refactor: fix types and update getAppsToTransfer * refactor: add confirm flag and construct app name * refactor: print error message and update lock.run call * refactor: initial refactor of apps:transfer tests * refactor: replace AppTransfer class with function and fix message output * refactor: test fixes * refactor: remove .only * refactor: add await to getConfig for test setup * fix: add app flag to AppsLock.run call and fix test * fix: add async await for commands that need the config * fix: add nock for addons:wait test api call * fix: fix apps:transfer test accounting for mac and windows formatting * fix: one more windows test fix for apps:transfer * refactor: remove orgs-v5 package directory * fix: update yarn.lock * refactor: remove import of orgs-v5 plugin from cli * refactor(pg-v5): Move command pg:settings:log-min-duration-statement to oclif (#2779) * Convert log min duration statement to oclif * Update import paths for types --------- Co-authored-by: Justin Wilaby <[email protected]> * Move 'pg:backups:cancel' to CLI * refactor(pg-v5): Move command pg:settings:log-lock-waits to oclif (#2772) * Convert log lock waits to oclif * Update log-lock-waits command to extend pg settings command * Use boolean function as Args.boolean seems broken * Update to use revised abstract class/booleanconverter * Set settingkey * Update paths for types --------- Co-authored-by: Justin Wilaby <[email protected]> * refactor(pg-v5): Move command pg:settings:auto-explain:log-nested-statements to oclif (#2778) * Convert log-nested-statements to oclif * Fix name of command * Update paths for types --------- Co-authored-by: Justin Wilaby <[email protected]> * migrate(W-14179932): pg-v5: Upgrade pg:settings:log-connections (#2784) * refactor(pg-v5): Move command pg:settings:log-statement to oclif (#2781) * Convert pg settings logstatement to oclif * Remove boolean converter * Remove .only * Update to reflect changes to setter.ts --------- Co-authored-by: Justin Wilaby <[email protected]> * Move command 'spaces:create' to CLI * Remove useless import on tests * Update yarn.lock * Removing unneeded files * Removing usage of non-null assertions * Adding missing tests for parsers lib * Move 'spaces:destroy' to CLI * Move 'spaces (index)' to CLI * Addressing PR feedback * Addressing PR feedback * migrate(W-14179949): pg-v5: Upgrade pg:settings:track-functions (#2791) * refactor(pg-v5): Move command pg:reset to oclif (#2801) * Convert pg:reset to oclif * Add remote flag option * refactor: migrate pg:copy to oclif/core (#2806) * refactor: initial migration of pg:copy command with some refactoring * refactor: migrate pg util parsePostgresConnectionString and tests * refactor: rename attachment util function to getAttachment * refactor: rename confirmApp util to confirm and move to lib directory * refactor: rename confirm to confirmCommand * refactor: complete migration of pg:copy * refactor: update host to hostname * refactor: migrate tests for pg:copy * fix: remove .only * refactor: add try-catch for backups.ts function and test fix * refactor: remove references to pg-v5 copy command * refactor: fix rebase error and add authorization for credentials call * migrate(W-14179971): pg-v5: Upgrade pg:bloat (#2800) * migrate(W-14179971): pg-v5: Upgrade pg:bloat * Update packages/cli/src/lib/pg/types.ts Co-authored-by: Santiago Bosio <[email protected]> * Optimized multisort --------- Co-authored-by: Santiago Bosio <[email protected]> * Move 'pg:blocking' to CLI * Move 'pg:connection-pooling:attach' to CLI * refactor(pg-v5): Move command pg:upgrade to oclif (#2803) * Convert pg upgrade to oclif * Remove .only * Fix await * Change to intersection * Remove semicolons, change db type * Update confirm helper name * Move 'pg:credentials' to CLI * Fixing authentication for Data API on mini databases * Merge updates from main (#2818) * release v8.11.2 (#2793) * v8.11.2 * Fix scripting errors * Bump heroku-color (#2797) * fix(authorizations): surface api warnings in temporary fix (#2804) * Surface api warnings for authorizations:create * Surface remaining api warnings for authorizations command * Add api warning header test for authorizations:create * Update response type in authorizations:info * release v8.11.3 (#2807) * v8.11.3 * Fix scripting errors * chore(telemetry): add environment variable to optionally disable telemetry (#2810) * Add DISABLE_TELEMETRY env variable & functionality * WIP create test for DISABLE_TELEMETRY env variable * Update DISABLE_TELEMETRY and remove wip test * Clean code up * release v8.11.4 (#2811) * v8.11.4 * Fix scripting errors * Fix failing test --------- Co-authored-by: Eric <[email protected]> * Move 'pg:killall' to CLI * Remove .only in test file * Move 'pg:kill' to CLI * Move 'pg:locks' to CLI * Move 'pg:outliers' to CLI * refactor(pg-v5): Move command pg:promote to oclif (#2822) * Convert pg promote to ocif * Convert pg promote test, clean up * Update to require database argument * Update packages/cli/src/commands/pg/promote.ts Co-authored-by: Santiago Bosio <[email protected]> * Update packages/cli/src/commands/pg/promote.ts Co-authored-by: Santiago Bosio <[email protected]> * Update packages/cli/src/commands/pg/promote.ts Co-authored-by: Santiago Bosio <[email protected]> * Remove semicolons, clean up test * Fix test * Fix lint --------- Co-authored-by: Santiago Bosio <[email protected]> * migrate(W-14180047): pg-v5: Upgrade pg:diagnose (#2814) * Convert pg:unfollow to oclif (#2826) * refactor(spaces): Move command spaces:info to oclif (#2830) * Convert spaces:info to oclif * remove .only * Fix new renderinfo usage * Remove commented out code * Convert spaces:rename to oclif (#2833) * refactor(spaces): Move command spaces:topology to oclif (#2835) * Convert spaces:topology to oclif * No need to set .sort as it is an in-place operation * refactor(pg-v5): Move command pg:vacuum-stats to oclif (#2827) * Convert vacuum stats to oclif * Cleanup * migrate(W-14180163): pg-v5: Upgrade pg:ps (#2829) * refactor(pg-v5): Move commands 'pg:pull' and 'pg:push' to CLI (#2846) * Moving incorrectly placed test files * Split and migrate command 'pg:push' * Remove 'async' from 'describe' and 'context' blocks on tests * Splat and migrated 'pg:pull' command. Removed unneeded files. * Fixing stub pollution from previous merged PR * migrate(W-14169186): spaces: Upgrade spaces:ps (#2836) * migrate(W-14169186): spaces: Upgrade spaces:ps * Added module scoped functions as class members * refactor(spaces): Move command outbound-rules to oclif (#2847) * Convert outbound-rules to oclif * remove topic override * Add outbound-rules alias * Add back in description for outbound rules * Add missing desc line, remove semicolon * refactor(spaces): Move command spaces:wait to oclif (#2841) * Covert spaces:wait to oclif * Remove semicolons * chore: add mocha eslint rules (#2848) * Add eslint mocha * Ignore eslint rules for js tests * Update to ignore js files in ci * Ignore js files in rc file * Update ignore patterns to just target js tests * Change some mocha errors to warns, autofix using arrow functions, fix misc linting errors * Update eslint versions, switch rejectedWith usage * Change tests to catch * FIx spacing * migrate(W-14169233): spaces: Upgrade drains:set (#2851) * refactor: migrate pg:info to cli/core (#2820) * refactor: add types for fetcher commands * refactor: update types * refactor: migrate pg:info command to oclif/core * refactor: add tests for pg:info * refactor: remove pg:info and tests from pg-v5 * refactor: add alias for pg:info * fix: rebase fix * fix: fix types * refactor(spaces): Move command spaces:peering:info to oclif (#2854) * Convert peering info to oclif * Update example to reflect whitespace * Rename to satisfy eslint * Update packages/cli/src/lib/spaces/format.ts Co-authored-by: Justin Wilaby <[email protected]> * Fix linting for pg:info test --------- Co-authored-by: Justin Wilaby <[email protected]> * refactor(spaces): Move command spaces:outbound:rules:add to oclif (#2852) * Convert outbound rules add to oclif * Clean up commented out code and examples * Fix typo * Fix output * Fix test expects for windows, add missing description * Update packages/cli/src/lib/spaces/outbound-rules.ts Co-authored-by: Justin Wilaby <[email protected]> * Update packages/cli/src/lib/spaces/outbound-rules.ts Co-authored-by: Justin Wilaby <[email protected]> * Update packages/cli/src/lib/spaces/outbound-rules.ts Co-authored-by: Justin Wilaby <[email protected]> * Fix array type --------- Co-authored-by: Justin Wilaby <[email protected]> * migrate(W-14169290): spaces: Upgrade outbound-rules:remove (#2853) * migrate(W-14169290): spaces: Upgrade outbound-rules:remove * Added the outbound-rules:remove alias * refactor: migrate pg:psql to oclif/core (#2855) * refactor: migrate psql command to oclif/core * refactor: initial migration of pg:psql tests * refactor: pg:psql test fixes * refactor: delete pg:psql from pg-v5 * fix: linting error in test * migeate(W-14169209): spaces: Upgrade spaces:transfer (#2837) * migeate(W-14169209): spaces: Upgrade spaces:transfer * Updated help and unit tests * migrate(W-14169349): spaces: Upgrade trusted-ips:add (#2859) * migrate(W-14169298): spaces: Upgrade spaces:peering:accept (#2856) * refactor(spaces): Move command spaces:peering:destroy to oclif (#2857) * Convert spaces:peering:destroy to oclif * Move info and destroy under peerings * Fix usage text * refactor(spaces): Move command spaces:vpn:config to oclif (#2862) * Convert vpn config to oclif * Fix output * refactor(spaces): Move command spaces:hosts to oclif (#2845) * Convert spaces:hosts to oclif * Fix output * Fix test data legibility. * Update packages/cli/src/commands/spaces/hosts.ts Co-authored-by: Santiago Bosio <[email protected]> * Add variant to hosts command --------- Co-authored-by: Santiago Bosio <[email protected]> * refactor(spaces): Move command spaces:peering:index to oclif (#2861) * Convert peering index to oclif * Update packages/cli/src/lib/spaces/peering.ts Co-authored-by: Justin Wilaby <[email protected]> --------- Co-authored-by: Justin Wilaby <[email protected]> * chore: remove pg:repoint (#2864) * refactor: migrate pg:repoint to oclif/core * refactor: remove pg:repoint * chore(cli): Merge updates from 'main' into 'prerelease/9.0.0-alpha' (#2866) * release v8.11.2 (#2793) * v8.11.2 * Fix scripting errors * Bump heroku-color (#2797) * fix(authorizations): surface api warnings in temporary fix (#2804) * Surface api warnings for authorizations:create * Surface remaining api warnings for authorizations command * Add api warning header test for authorizations:create * Update response type in authorizations:info * release v8.11.3 (#2807) * v8.11.3 * Fix scripting errors * chore(telemetry): add environment variable to optionally disable telemetry (#2810) * Add DISABLE_TELEMETRY env variable & functionality * WIP create test for DISABLE_TELEMETRY env variable * Update DISABLE_TELEMETRY and remove wip test * Clean code up * release v8.11.4 (#2811) * v8.11.4 * Fix scripting errors * chore: update opentelemetry/instrumentation to 0.50.0 and improve integration test runs (#2834) * chore: update opentelemetry/instrumentation to 0.50.0 * chore: change ubuntu runner for integration tests * chore: change integration runner back to ubuntu-latest * chore: remove macos run from integration tests * test: try out run integration tests without oclif/test * Revert "test: try out run integration tests without oclif/test" This reverts commit 2ed9824. * chore: remove run-v5 integration test run * test: run integration test suites separately * test: testing location * test: fix directory location for orgs-v5 integration tests * fix: add quotation marks around public key in sign/deb script (#2849) * chore(auth): update warning copy (#2842) * Update auth copy & tests * Update test * release v8.11.5 (#2850) * v8.11.5 * fix: add missing links back to CLI readme * chore: separate unit testing and linting (#2858) * Updated 'heroku-cli-util' dependency version and its dependencies (#2863) * Updating yarn.lock after merge * Fixing test * Removing integration tests for deleted orgs-v5 package * Fixing tests --------- Co-authored-by: Zane Whitfield <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: Katy Bowman <[email protected]> * refactor(spaces): Move command spaces:vpn:info to oclif (#2869) * Convert vpn:info to oclif * Remove name as a flag field * migrate(W-14169383): spaces: Upgrade trusted-ips:remove (#2868) * mirate(W-14169356): spaces: Upgrade trusted-ips (#2867) * refactor(spaces): Move command 'spaces:drains:get' to CLI (#2871) * Move command 'spaces:drains:get' to CLI * Changing topic from 'drains' to 'spaces' * Adjusting topic for other 'spaces' subcommands for consistency * refactor: migrate pg:wait to oclif/core (#2872) * refactor: initial migration of pg:wait * refactor: complete migration of pg:wait * refactor: delete unneeded imports * refactor: migrate tests * refactor: fix tests and wait command * refactor: delete pg-v5 package * chore: remove semicolons and update wait_status call * Move command 'spaces:vpn:connect' to CLI (#2873) * Move command 'spaces:vnp:destroy' to CLI (#2874) * Move command 'spaces:vpn:update' to CLI (#2876) * refactor: migrate spaces:vpn:wait to oclif/core (#2877) * refactor: initial spaces:vpn:wait command migration * refactor: complete migration of vpn:wait command * refactor: fix errors, add json printing, and replace spinner with ux.action * refactor: migrate tests for spaces:vpn:wait * remove spaces:vpn:wait command from spaces package * fix: remove .only * refactor(spaces): Move command 'spaces:vpn:connections' to CLI (#2875) * Move command 'spaces:vpn:connections' to CLI * Migrating missing unit tests for lib file * Removing package 'spaces' * Align changes introduced post-migration on CLI commands (#2879) * refactor: migrate run commands to use oclif/core v2 (#2880) * refactor: migrate run command to oclif/core v2 * refactor: migrate run:detached command to oclif/core v2 * refactor: migrate run:inside command to oclif/core v2 * refactor: remove unneeded packages * refactor: delete run-v5 package * update yarn.lock * refactor(cli): Resolve hidden aliases (#2878) * Adding --no-aliases to 'oclif readme' runs * Refactor hidden aliases * Remove aliases from commands-output.ts * Updating @oclif/core to v2.16.0 and required dependencies * refactor(cli): Remove plugins 'oauth-v5' and 'certs-v5' from prerelease branch (#2881) * Removing plugins 'oauth-v5' and 'certs-v5' * Removing 'certs:key' and 'certs:chain' from acceptance test * chore: remove the migration package (#2884) * chore: remove the migration package * chore: remove migration scripts from package.json * fix package.json * Remove env flag for run:inside (#2886) * Update lockfile * chore: remove unnecessary uses of Lerna and bump version of oclif used in the cli package (#2892) * chore: remove unnecessary uses of Lerna * chore: bump version of oclif used in the cli package * refactor: use Lerna to run unit tests * chore: fix descriptions and other docs issues (#2893) * chore: fix descriptions and other docs issues * fix: test and linting fixes * fix: update commands output * fix: more commands-output updates * fix: yet another commands-output update * fix: moar commands-output updates * v9.0.0-alpha.2 (#2894) * fix(W-15838634): plugins --json yields TypeError: Converting circular structure to JSON (#2895) * fix(W-15954887): json flag yelds error for command: heroku commands --json (#2897) * fix: move tsheredoc to dependencies (#2899) * v9.0.0-alpha.3 (#2900) * fix(container): Error out `container:push` command if not `container` stack (#2898) * implement * fix: pull test * fix: releases test assertion * fix: push test * fix: release test * fix: rm test * fix: run test * fix: try block * review * Bump version of @heroku-cli/command for delinquency notifications (#2906) * fix(cli): Change to require either app or pipeline (#2907) * Change to require either app or pipeline * Add test for requiring app or pipeline remove .only Remove tsheredoc import * Add missing char shortcut for --space (#2908) * fix: update spaces:vpn commands to improve consistency in args and flags (#2909) * fix: update spaces:vpn commands to improve consistency in args and flags * fix: spaces:vpn:wait test fixes * fix: update args descriptions * fix: add short char for the team flag on spaces:transfer (#2912) * docs: add documentation on how to add config items for addons:create (#2910) * docs: add documentation on how to add config items for addons:create * fix: update commands-output * Fix bug with git remote creation (#2911) * refactor: remove outbound-rules commands due to endpoint removal (#2913) * refactor: remove outbound-rules commands due to endpoint deprecation * refactor: remove outbound-rules tests * refactor: remove ref to outbound-rules in cli package.json * chore(cli): Declaratively require pipeline or app across ci:config commands (#2914) * Declaratively require pipeline or app across ci:config commands * Update test * chore: reapply bump filesize from 4.0.0 to 10.1.2 * v9.0.0-beta.0 (#2917) * chore: remove alpha versions and reset changelogs * v9.0.0-beta.0 * fix: rollback plugin-plugins to 2.4.3 (#2918) * v9.0.0-beta.1 (#2919) * fix: correct error handling in matchesHelper (#2921) * v9.0.0-beta.2 (#2922) * fix: second attempt at fixing the error handling in matchesHelper (#2923) * v9.0.0-beta.3 (#2924) * chore: remove beta release from package.json and roll back changelogs (#2925) * trigger tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: Justin Wilaby <[email protected]> Co-authored-by: Santiago Bosio <[email protected]> Co-authored-by: Zane Whitfield <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Wilaby <[email protected]> Co-authored-by: Benjamin Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
drains:setto the CLI and migrates to TypeScriptTest Instructions
yarn && yarn build && cd/packages/cli./bin/run drains:set DRAIN_URL --space YOUR_SPACE