-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite of TPS integrations using basic bash scripts #3090
base: main
Are you sure you want to change the base?
Conversation
1991c07
to
13226f0
Compare
…the 204 status for success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm! had one thing i noticed that should be fixed and one question/comment.
Thanks for the tight reviews y'all! Please give it your ✅ approval or more feedback for changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome.
Through work & pairing with @halorgium, we've got a more testable approach for CLI's TPS integrations.
The scripts
release/tps_check_lock
&postrelease/tps_record_release
are now similar bash scripts, making these much easier to reason about.They each:
curl
command capturing response status code and response body