Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of TPS integrations using basic bash scripts #3090

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

mars
Copy link
Member

@mars mars commented Nov 13, 2024

Through work & pairing with @halorgium, we've got a more testable approach for CLI's TPS integrations.

The scripts release/tps_check_lock& postrelease/tps_record_release are now similar bash scripts, making these much easier to reason about.

They each:

  1. parse env vars & arguments, returning clear error messages for missing inputs
  2. implemented as a single curl command capturing response status code and response body
  3. retry using a basic loop, with sensible timeouts for each
    1. 10-minutes for checking the lock
    2. 30-minutes for recording the release
  4. logs clear error message (response status & body) during retries

@mars mars changed the title Speculative rewrite of TPS lock check Rewrite of TPS integrations using basic bash scripts Nov 13, 2024
@mars mars requested a review from k80bowman November 14, 2024 00:02
@mars mars marked this pull request as ready for review November 14, 2024 01:08
@mars mars requested a review from a team as a code owner November 14, 2024 01:08
@mars mars requested a review from eablack November 14, 2024 01:09
scripts/postrelease/tps_record_release Outdated Show resolved Hide resolved
scripts/release/tps_check_lock Outdated Show resolved Hide resolved
scripts/postrelease/tps_record_release Outdated Show resolved Hide resolved
.github/workflows/promote-release.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm! had one thing i noticed that should be fixed and one question/comment.

.github/workflows/create-cli-release.yml Outdated Show resolved Hide resolved
.github/workflows/promote-release.yml Outdated Show resolved Hide resolved
@mars
Copy link
Member Author

mars commented Nov 14, 2024

Thanks for the tight reviews y'all! Please give it your ✅ approval or more feedback for changes.

Copy link
Contributor

@halorgium halorgium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants