-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove corepack tooling to install package managers #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Corepack will no longer be bundled with Node.js starting with the 25.0.0 release. For this buildpack the Corepack tooling is not actually required to install a package manager, it was just a convenient alternative. It's simpler to just remove the tooling and switch to installing the requested package managers using the npm registry. This means developers can still choose to use Corepack tooling locally and this buildpack will respect their configuration via the `packageManager` field in `package.json`. [Node.js TSC Vote](nodejs/TSC#1697 (comment)) [Node.js v25.0.0 Release Notes](https://github.com/nodejs/node/releases/tag/v25.0.0) [Node.js v25.0.0 Corepack docs](https://nodejs.org/dist/latest/docs/api/corepack.html)
Signed-off-by: Colin Casey <[email protected]>
schneems
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, requested in chat: Can you write me a changelog entry for the heroku site that tells me what a customer should expect from their perspective?
i.e. if they were previously relying on this behavior what just works and what needs adjustment? Any likely failure modes? Anything they can do about them?
| VENDOR_PATH=$(get_yarn_path "$BUILD_DIR") | ||
|
|
||
| # if we're installing yarn via corepack we don't need to fail | ||
| # if we're installing yarn via packageManager we don't need to fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're referencing the variable in the code which is snake case.
| # if we're installing yarn via packageManager we don't need to fail | |
| # if we're installing yarn via package_manager we don't need to fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think this refers to the packageManager field of the customer's app.
Corepack will no longer be bundled with Node.js starting with the 25.0.0 release. For this buildpack the Corepack tooling is not actually required to install a package manager, it was just a convenient alternative. It's simpler to just remove the tooling and switch to installing the requested package managers using the npm registry.
This means developers can still choose to use Corepack tooling locally and this buildpack will respect their configuration via the
packageManagerfield inpackage.json.Node.js TSC Vote
Node.js v25.0.0 Release Notes
Node.js v25.0.0 Corepack docs
W-20075541, W-20075528