Skip to content

test: use remote coverage #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

test: use remote coverage #945

merged 2 commits into from
Jun 11, 2025

Conversation

lukasmetzner
Copy link
Contributor

@lukasmetzner lukasmetzner commented Jun 6, 2025

We have already implemented this in the csi-driver. With this solution we can test more paths (e.g., metrics) in the code and get a more accurate test coverage.

@lukasmetzner lukasmetzner requested a review from a team as a code owner June 6, 2025 15:50
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (c155741) to head (b9dff56).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
main.go 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   63.72%   70.05%   +6.33%     
==========================================
  Files          29       22       -7     
  Lines        3225     3046     -179     
==========================================
+ Hits         2055     2134      +79     
+ Misses       1007      743     -264     
- Partials      163      169       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can test more paths (e.g., Robot)

Do you plan to add this in a follow-up PR?

@lukasmetzner
Copy link
Contributor Author

we can test more paths (e.g., Robot)

Do you plan to add this in a follow-up PR?

Actually, I have made a mistake here. It should be (e.g., Metrics), as we do not upload the Robot coverage. I will correct the PR description.

Tackling the Robot coverage would be nice though.

@lukasmetzner lukasmetzner merged commit eda8064 into main Jun 11, 2025
11 checks passed
@lukasmetzner lukasmetzner deleted the test-fetch-remote-coverage branch June 11, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants