Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 63.72% 70.05% +6.33%
==========================================
Files 29 22 -7
Lines 3225 3046 -179
==========================================
+ Hits 2055 2134 +79
+ Misses 1007 743 -264
- Partials 163 169 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apricote
approved these changes
Jun 10, 2025
Member
apricote
left a comment
There was a problem hiding this comment.
we can test more paths (e.g., Robot)
Do you plan to add this in a follow-up PR?
Contributor
Author
Actually, I have made a mistake here. It should be Tackling the Robot coverage would be nice though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have already implemented this in the csi-driver. With this solution we can test more paths (e.g., metrics) in the code and get a more accurate test coverage.