fix: feature gate cannot be enabled #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b8cbf4. Using `fix` to trigger a new patch release.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
==========================================
- Coverage 71.27% 67.46% -3.81%
==========================================
Files 22 22
Lines 3046 3046
==========================================
- Hits 2171 2055 -116
- Misses 706 828 +122
+ Partials 169 163 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We might not fully revert commit 6b8cbf4. Putting this PR in draft to keep the current PR description, while continuing work on this topic. |
lukasmetzner
force-pushed
the
revert-k8s-version-override
branch
from
31e120c to
a5e6851
Compare
lukasmetzner
commented
Jul 16, 2025
lukasmetzner
changed the title
apricote
approved these changes
Jul 16, 2025
lukasmetzner
pushed a commit
that referenced
this pull request
Jul 18, 2025
This release introduces an experimental feature to address #395. ### Watch-Based Route Reconciliation (Experimental) Currently, route reconciliation is performed at a fixed interval of 30s. This leads to unnecessary API requests, as a `GET /v1/networks/{id}` call is triggered every 30s, even when no changes have occurred. Upstream we have proposed an event-driven approach, similar to the mechanism used by other controllers such as the Load Balancer Controller. With this new approach, route reconciliation is triggered on node additions, node deletions, or when the `PodCIDRs` or `Addresses` of nodes change. Additionally, to ensure consistency, reconciliation will still occur periodically at a randomized interval between 12 and 24 hours. We are close to merging a Kubernetes Enhancement Proposal (KEP). Furthermore, a work-in-progress pull request containing the implementation is already open in the Kubernetes repository. #### Forked Upstream Libraries In this release, we replaced the upstream `controller-manager` and `cloud-provider` libraries with our own forks. These forks are based on the upstream `v0.33.2` release (aligned with Kubernetes v1.33.2) and include our patches on top. #### Enabling the Feature This feature is **disabled by default** and will not impact existing deployments unless explicitly enabled. We **do not recommend** running this feature in production environments at this stage. However, we welcome early testers who can try it in non-critical setups. Running with this feature active is enough for us to analyze its impact. No additional feedback is required. To enable the feature, set the following Helm value: `args.feature-gates=CloudControllerManagerWatchBasedRoutesReconciliation=true` ### Bug Fixes - feature gate cannot be enabled (#980)
lukasmetzner
pushed a commit
that referenced
this pull request
Jul 18, 2025
This release introduces an experimental feature to address #395. ### Watch-Based Route Reconciliation (Experimental) Currently, route reconciliation is performed at a fixed interval of 30s. This leads to unnecessary API requests, as a `GET /v1/networks/{id}` call is triggered every 30s, even when no changes have occurred. Upstream we have proposed an event-driven approach, similar to the mechanism used by other controllers such as the Load Balancer Controller. With this new approach, route reconciliation is triggered on node additions, node deletions, or when the `PodCIDRs` or `Addresses` of nodes change. Additionally, to ensure consistency, reconciliation will still occur periodically at a randomized interval between 12 and 24 hours. We are close to merging a Kubernetes Enhancement Proposal (KEP). Furthermore, a work-in-progress pull request containing the implementation is already open in the Kubernetes repository. #### Forked Upstream Libraries In this release, we replaced the upstream `controller-manager` and `cloud-provider` libraries with our own forks. These forks are based on the upstream `v0.33.2` release (aligned with Kubernetes v1.33.2) and include our patches on top. #### Enabling the Feature This feature is **disabled by default** and will not impact existing deployments unless explicitly enabled. We **do not recommend** running this feature in production environments at this stage. However, we welcome early testers who can try it in non-critical setups. Running with this feature active is enough for us to analyze its impact. No additional feedback is required. To enable the feature, set the following Helm value: `args.feature-gates=CloudControllerManagerWatchBasedRoutesReconciliation=true` ### Bug Fixes - feature gate cannot be enabled (#980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s.io/component-base/versionprovides a standardized way for Kubernetes components to embed and expose their version information. Currently, our build scripts overwrite the upstream version (e.g v1.32, v1.33) with the current HCCM version (e.g v1.26, v1.27). This was done to correct a log message fromk8s.io/cloud-provider, which reportedVersion v0.0.0-master+$Format:%H$Our feature gate
CloudControllerManagerWatchBasedRoutesReconciliation, which is currently tested in HCCMv1.27.0-alpha.0, requires Kubernetes >= v1.33. This is currently broken, as thek8s.iolibraries will report, that the current Kubernetes version is to low.Instead of reverting 6b8cbf4, we are replacing
$Format:%H$with the current HCCM version, e.g.:v0.0.0-master+v1.27.0. This adds the relevant information to the log message and does not break enabling the feature gate.