OpenTelemetry template: use the interface name without the package as the default span name prefix #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR take care of #101.
Take for example this interface :
When the interface and the generated file are in the same package, the span names start with the interface name like this
MyInterface.MyMethod
. This PR doesn't change that.When the interface and the generated file are NOT in the same package, the span name had an additional prefix that include the interface package. It used to be
mypackage.MyInterface.MyMethod
but after #92 it became_sourceMypackage.MyInterface.MyMethod
.With this PR, the default span name is always the same whether the interface and the generated file are in the same package or not i.e.
MyInterface.MyMethod
.This is also possible to change default span name prefix with the
SpanNamePrefix
variable. ForSpanNamePrefix=NewInterface
, the generated span name would beNewInterface.MyMethod
. If you want to include the package name, include it in the variable:SpanNamePrefix="mypackage.MyInterface"
.