fix(asset): prevent removal of programmatically created assets #5702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes issue #5680 where programmatically created assets in processors were being removed by the asset generator.
The asset generator was checking for physical file existence and removing all assets without corresponding files, including those created programmatically with
modified: trueflag.Solution
Modified the asset generator to skip removal for assets marked with
modified: true. This allows plugins and processors to create virtual/assets programmatically that persist in the database.Changes Made
lib/plugins/generator/asset.ts: Added check forasset.modifiedflag before removing assetstest/scripts/generators/asset.test.js: Added comprehensive testsPull request tasks
Testing
Example Usage