-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update] new hints in the example of github-pages.md #1979
Conversation
There are some issues with this document. - Github do not support the name of token starting with `GITHUB_` now. - The name of `token` in the `pages.yml` is ambiguous. User may check the usage of actions.
Theme name validation passed. |
The |
Sorry, I clicked the "Close Pull Request" button by mistake. |
See also github/docs#12095 (comment) |
@renbaoshuo Thanks for your fast response! I have trid to use the token starts with But, I got a failed message below In my opion, we need to change the name of token in the document or they may confuse the user. |
The token named |
@stevenjoezhang Thanks! I followed the step here https://hexo.io/zh-tw/docs/github-pages.html and created a new repo to test the workflows. In the stage of deployment, it showed error of 403: |
It is working in my repository... Maybe you can refer to peaceiris/actions-gh-pages#744 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking the pull request as the change requires further discussion/investigation.
@stevenjoezhang Thanks! In that reference, we need to switch the setting in actions. I find there is another way to give writting permission. -> peaceiris/actions-gh-pages#753 Just add permissions in the
|
There are some issues with this document.
Github do not support the name of token starting with
GITHUB_
.Check the issue here -> The documentation suggests an invalid value for the name of a secret github/docs#12094
The name of
token
in thepages.yml
is ambiguous. User may check the usage of actions.Check List
Please read and check followings before submitting a PR.
name
is unique.link
URL is correct.preview
URL is correct.preview
URL web site is rendered correctly.source/themes/screenshots
.name
.800 * 500
.png
.name
is unique.link
URL is correct.en
Englishru
Russianzh-cn
simplified Chinesezh-tw
traditional Chinese