Skip to content

fix(clients): annotate serializer return types#2277

Merged
mrlubos merged 1 commit intomainfrom
fix/client-serializer-return-type
Jul 4, 2025
Merged

fix(clients): annotate serializer return types#2277
mrlubos merged 1 commit intomainfrom
fix/client-serializer-return-type

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Jul 4, 2025

Closes #2271

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 10:03pm

@mrlubos mrlubos marked this pull request as ready for review July 4, 2025 21:47
@mrlubos mrlubos force-pushed the fix/client-serializer-return-type branch from bbf0311 to 25fc54c Compare July 4, 2025 22:02
@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: 25fc54c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2277
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2277
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2277

commit: 25fc54c

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 24.04%. Comparing base (63645d0) to head (25fc54c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...gins/@hey-api/client-core/bundle/bodySerializer.ts 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
- Coverage   24.05%   24.04%   -0.01%     
==========================================
  Files         313      313              
  Lines       28892    28896       +4     
  Branches     1227     1227              
==========================================
  Hits         6949     6949              
- Misses      21934    21938       +4     
  Partials        9        9              
Flag Coverage Δ
unittests 24.04% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos mrlubos merged commit 897cffa into main Jul 4, 2025
16 of 17 checks passed
@mrlubos mrlubos deleted the fix/client-serializer-return-type branch July 4, 2025 22:08
@github-actions github-actions bot mentioned this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated code causes TS2742 error due to inferred FormData type from undici-types

1 participant