Add chall solves #52
Open
Add chall solves #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfz1337
reviewed
Jun 21, 2025
Comment on lines
1435
to
1439
| embed.add_field( | ||
| name=name, | ||
| value=f"{time_since(solver.solved_at)}", | ||
| inline=False, | ||
| ) |
There was a problem hiding this comment.
Instead of introducing a new helper function for this, it would be cleaner and more efficient to use Discord's built-in relative timestamp format (<t:${timestamp}:R>). It automatically shows the relative time and updates in real time, so there's no need to handle that manually.
hfz1337
reviewed
Jun 21, 2025
| @@ -37,6 +38,7 @@ | |||
| get_ctf_info, | |||
| sanitize_channel_name, | |||
| strip_url_components, | |||
| time_since, | |||
hfz1337
reviewed
Jun 21, 2025
Comment on lines
+1358
to
+1360
| """ | ||
| Show the list of solvers for the provided/current challenge. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """ | |
| Show the list of solvers for the provided/current challenge. | |
| """ | |
| """Show the list of solvers for a given challenge. | |
| Args: | |
| interaction: The interaction that triggered this command. | |
| name: The challenge name (default: current thread's challenge). | |
| """ |
hfz1337
reviewed
Jun 21, 2025
Comment on lines
+1362
to
+1384
| async def followup(content: str, ephemeral=True, **kwargs) -> None: | ||
| if not interaction: | ||
| return | ||
| await interaction.followup.send(content, ephemeral=ephemeral, **kwargs) | ||
|
|
||
| await interaction.response.defer() | ||
|
|
||
| if name is None: | ||
| challenge = get_challenge_info(thread=interaction.channel_id) | ||
| if challenge is None: | ||
| await followup( | ||
| ( | ||
| "Run this command from within a challenge thread, " | ||
| "or provide the name of the challenge you wish to stop " | ||
| "working on." | ||
| ) | ||
| ) | ||
| return | ||
| else: | ||
| challenge = get_challenge_info(name=name) | ||
| if challenge is None: | ||
| await followup("No such challenge.") | ||
| return |
There was a problem hiding this comment.
The followup function is not needed since interaction will never be None.
hfz1337
reviewed
Jun 21, 2025
| return | ||
|
|
||
| solvers = [] | ||
|
|
hfz1337
reviewed
Jun 21, 2025
|
|
||
| embed = None | ||
| num_fields = 0 | ||
|
|
hfz1337
reviewed
Jun 21, 2025
Comment on lines
+1413
to
+1414
| # If we reached Discord's maximum number of fields per | ||
| # embed, we send the previous one and create a new one. |
There was a problem hiding this comment.
Maximum line length in this project is 88 chars
Suggested change
| # If we reached Discord's maximum number of fields per | |
| # embed, we send the previous one and create a new one. | |
| # If we reached Discord's maximum number of fields per embed, we send the | |
| # previous one and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created "/ctf showsolvers" command.
Optional option: name
Description: