Added scraper for Drinkoteket.se #1043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Pebkac03
changed the title
Pebkac03
changed the title
Pebkac03
changed the title
jayaddison
reviewed
Mar 25, 2024
jayaddison
reviewed
Mar 25, 2024
|
Hi @Pebkac03, just a quick note. If you add |
|
Thanks, I will do that. I realized that the site has a tendency of not having a standard way of doing many things leading me to suspect a substantial risk of annoying edge cases requiring a lot of testing to be certain of it being bug-free which I currently do not have the time for. You could either merge it as is if you want, there are very few recipes with a differing serving amount or if you feel it needs to be more stable, mark it as a draft and I'll do it sometime in the future unless anyone else wants to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a scraper for Drinkoteket.se.
This one was a bit tricky with the ingredients since they don't provide amounts in their schema. This works by parsing a list from the HTML with ingredients and then removing everything below the separator since those elements aren't part of the ingredients.
Resolves #1042