Skip to content

Conversation

@nrayburn-tech
Copy link

@nrayburn-tech nrayburn-tech commented Dec 1, 2025

This adds Jackson 3 support alongside the existing Jackson 2 support.

  1. If Jackson 3 is available, it is the preferred option with the automatic detection. This might be undesirable, so it may be worth changing before removing.
  2. OSON doesn't support Jackson 3 right now.
  3. There is duplicate code between the Jackson 2 and Jackson 3 support. There could likely be some refactoring done to reduce this if that's desired (either in this PR or a separate one).
  4. I'm not sure if there are missing tests for this.
  5. I didn't test this in a separate project or anything, just ./gradlew clean build.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19890

* @author Christian Beikov
* @author Yanming Zhou
* @author Nick Rayburn
*/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the previous author's need to be retained. This file was copied from the existing one that they were on. (I also don't need my name in here either unless it's the project standard, just tried to match what I copied from.)

}

private static XmlMapper createXmlMapper(List<JacksonModule> modules, boolean legacyFormat) {
final XmlMapper.Builder builder = XmlMapper.builder().addModules( modules );
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jackson 2 mapper has 2 configuration options here. Those configuration values had their defaults changed for Jackson 3, so they don't need to be configured anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant