Skip to content

Review Apps #12172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 58 commits into
base: master
Choose a base branch
from
Draft

Review Apps #12172

wants to merge 58 commits into from

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented May 16, 2025 •
edited
Loading

TODO

  • Create Terraform S3 bucket named terraform
  • Add DIGITALOCEAN_TOKEN, AWS_ACCESS_KEY_ID, and AWS_SECRET_ACCESS_KEY GitHub secrets
  • Set up Hashicorp vault
  • Update variables passed to Terraform config (e.g. environment, image_tag, etc)
  • Switch deployment to only start when a /deploy comment is added to the PR
  • Add "scale to 0" if feasible

Link to Issue

Closes: #TODO

Description of Changes

Test Plan

Deployment Plan

Other Considerations

@timolegros timolegros changed the title Neon CI Review Apps May 17, 2025
@timolegros
Copy link
Collaborator Author

/deploy

timolegros added 19 commits May 28, 2025 11:20
timolegros added 30 commits May 30, 2025 18:22
@timolegros
attempt to pull image before building + fixed terraform secrets/port …
f9462a9 
…issue
@timolegros
skip build if image exists + pass correct variables to terraform plan
a0ed801
@timolegros
log manifest output
1e775a5
@timolegros
don't throw on unknown manifest
8eb4ecc
@timolegros
split tf into 2 stages
0bcc5e9
@timolegros
update terraform variables
89a4fee
@timolegros
fix duplicate local name
539263e
@timolegros
add debug log
91821d9
@timolegros
use directories instead of targets to avoid declaring dummy variables
e7d35f5
@timolegros
update variables
65ac8cb
@timolegros
remove release build + update size names
0015ee4
@timolegros
update droplet size
2fddcae
@timolegros
fix k8 config
a0d554a
@timolegros
updated env var management via Vault
b7813f8
@timolegros
Use HCP GH actions + update logs in HCP script
dd5418e
@timolegros
fix workflow + hcp auth
78df659
@timolegros
fix cli usage in script + add logging for database url
fb2f387
@timolegros
fix k8s plan step + use Neon action to check if branch exists + set k…
334239a 
…8 info as sensitive
@timolegros
2 stage plan/apply for CRDs
0cb481f
@timolegros
re-order steps
dd77ed7
@timolegros
fix database url
c0c323d
@timolegros
comment
3e5718a
@timolegros
add computed field
590b442
@timolegros
3 stage Terraform config
edea8f6
@timolegros
update stakater reloader helm chart version
56a7da6
@timolegros
fix state file name
e4b1015
@timolegros
fix app/main.tf terraform config
2123c7c
@timolegros
update slug version
7e3570c
@timolegros
try updated hcp provider
9e87e8e
@timolegros
add refresh
ee28457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rotorsoft Rotorsoft Awaiting requested review from Rotorsoft Rotorsoft will be requested when the pull request is marked ready for review Rotorsoft is a code owner

@kurtassad kurtassad Awaiting requested review from kurtassad kurtassad will be requested when the pull request is marked ready for review kurtassad is a code owner

@rbennettcw rbennettcw Awaiting requested review from rbennettcw rbennettcw will be requested when the pull request is marked ready for review rbennettcw is a code owner

@dillchen dillchen Awaiting requested review from dillchen dillchen will be requested when the pull request is marked ready for review dillchen is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timolegros