solana ce first pass #12239
solana ce first pass #12239
Conversation
|
|
||
| // Check if directory exists | ||
| if (!existsSync(dirPath)) { | ||
| console.warn(`IDL directory not found: ${dirPath}`); |
There was a problem hiding this comment.
Should replace all console logs with our logger created with const log = logger(import.meta)
There was a problem hiding this comment.
the logger package(commonwealth core) isnt imported in evm-protocols, should we import it?
| @@ -0,0 +1,149 @@ | |||
| /** | |||
There was a problem hiding this comment.
If we don't expect the number of idls to grow it may be simpler to just import the JSON directly rather than having functions to read the files dynamically.
There was a problem hiding this comment.
I think given this works we could stick with this approach unless there is an issue with it - idls may or may not grow, we never know(lol) and this allows for the fastest addition with the least code changes when a new program or network is added with the upfront complexity here.
| @@ -0,0 +1,28 @@ | |||
| import Sequelize from 'sequelize'; | |||
There was a problem hiding this comment.
Is there a reason we create a new table instead of just renaming the other table to LastProcessedBlock?
There was a problem hiding this comment.
Cursors justification was query performance per worker and table organization. I can refactor to use LastProcessedBlock if we dont want an extra table
| ), | ||
| LOG_TRACE: process.env.SOLANA_CE_LOG_TRACE !== 'false', | ||
| MAX_SLOT_RANGE: parseInt( | ||
| process.env.SOLANA_CE_MAX_SLOT_RANGE ?? '100', |
There was a problem hiding this comment.
I think we can increase default value by a lot. Alchemy limits for EVM are much higher so I presume Solana is similar. Should research the exact slot limit Alchemy sets and then use that.
There was a problem hiding this comment.
Could not find alchemy docs on this but bumped to 10000
packages/commonwealth/server/workers/solanaChainEvents/nodeProcessing.ts
Outdated
Show resolved
Hide resolved
ianrowan
requested review from
Rotorsoft,
kurtassad,
rbennettcw and
dillchen
as code owners
Link to Issue
Closes: #12186
Description of Changes