Add unit tests #99
Merged
Add unit tests #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiminhsieh
commented
Sep 17, 2019
| @@ -89,7 +89,7 @@ class MixedDataset(sqlCtx: SQLContext) { | |||
| Dataset[(RawPanda, CoffeeShop)] = { | |||
| //tag::joinWith[] | |||
| val result: Dataset[(RawPanda, CoffeeShop)] = pandas.joinWith(coffeeShops, | |||
| $"zip" === $"zip") | |||
| pandas("zip") === coffeeShops("zip")) | |||
There was a problem hiding this comment.
Below log is the reason I need to change as above:
[info] - self join *** FAILED ***
[info] org.apache.spark.sql.AnalysisException: Reference 'zip' is ambiguous, could be: zip#178, zip#195.;
[info] at org.apache.spark.sql.catalyst.plans.logical.LogicalPlan.resolve(LogicalPlan.scala:287)
jiminhsieh
commented
Sep 17, 2019
| val result: Dataset[(RawPanda, RawPanda)] = pandas.joinWith(pandas, | ||
| $"zip" === $"zip") | ||
| val result: Dataset[(RawPanda, RawPanda)] = pandas.as("l").joinWith(pandas.as("r"), | ||
| $"l.zip" === $"r.zip") |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 44.76% 48.48% +3.71%
==========================================
Files 39 33 -6
Lines 994 959 -35
Branches 35 21 -14
==========================================
+ Hits 445 465 +20
+ Misses 549 494 -55Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #64.
Finish the rest of the unit tests of WordCountTest, AccumulatorsTest, and MixedDatasetSuite.
In the same time, I add comment mark to ignore coverage of the main method.