Add polls support #2219
Merged
Add polls support #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an `attrs` class with `weakref_slot=False` at the same time as a
predefined `__slots__` will cause `attrs` to throw a fit:
TypeError: 'property' object is not iterable
...oops Signed-off-by: PythonTryHard <[email protected]>
added `_serialize_poll_media()` and fixed polls question serialisation.
The removal of the counter has been added, so that the user can choose there own options, however, they may need to add a check because in its current form, you can override other answers.
Co-authored-by: MPlatypus <[email protected]>
"Apparently".
- De-underscore `answer_payload`. - Remove unnecessary `dict.get` from `deserialize_poll`. - Streamline serialization of poll in `_build_message_payload`. - API endpoint naming consistency. - Correct typing targeting Python 3.8 Co-authored-by: davfsa <[email protected]> Signed-off-by: PythonTryHard <[email protected]>
…ged poll end route name, docs rewording and general housekeeping.
davfsa
requested changes
Mar 20, 2025
davfsa
reviewed
Mar 20, 2025
…Builder, which now takes a ext and/or emoji object instead of a PollMediaBuilder.
davfsa
requested changes
Mar 20, 2025
Co-authored-by: davfsa <[email protected]> Signed-off-by: Platy <[email protected]>
Co-authored-by: davfsa <[email protected]> Signed-off-by: Platy <[email protected]>
Co-authored-by: davfsa <[email protected]> Signed-off-by: Platy <[email protected]>
Co-authored-by: davfsa <[email protected]> Signed-off-by: Platy <[email protected]>
Co-authored-by: davfsa <[email protected]> Signed-off-by: Platy <[email protected]>
davfsa
reviewed
Mar 21, 2025
Co-authored-by: davfsa <[email protected]> Signed-off-by: Platy <[email protected]>
davfsa
previously approved these changes
Mar 21, 2025
Signed-off-by: davfsa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding polls to hikari
Checklist
noxand all the pipelines have passed.Related issues
Closes #1886