API deprecations #47
Open
API deprecations #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 3, 2019 13:48
Wrapping a Maybe around the userLang field (which was done in a previous commit) was just the tip of the iceberg. There are many other fields that are now nullable that weren't previously and will cause JSON parsing errors. We *could* just wrap Maybes around all of those fields, but as those fields are always going to be null from now on, it's probably better to just remove them altogether. https://twittercommunity.com/t/upcoming-changes-to-user-object-and-get-users-suggestions-endpoints/124732
Perhaps this was once a field in the User object, but it is no longer. https://developer.twitter.com/en/docs/tweets/data-dictionary/overview/user-object
|
Note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 partially addressed these announced Twitter API changes, but JSON parsing of User objects will still fail unless the rest of the deprecated fields are fixed.
This PR removes all of the deprecated fields altogether. The Twitter documentation states that those fields will only have a value of
nullfrom now on anyway.