Feat/chakra v3 #1912
Merged
Feat/chakra v3 #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BLuEScioN
force-pushed
the
feat/chakra-v3
branch
from
b7777ee to
c700565
Compare
BLuEScioN
force-pushed
the
feat/chakra-v3
branch
from
73d4b2b to
19f83a2
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
He1DAr
approved these changes
Jan 17, 2025
BLuEScioN
force-pushed
the
feat/chakra-v3
branch
from
5853d82 to
df9cd41
Compare
|
🎉 This PR is included in version 1.243.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1903
What type of PR is this? (check all applicable)
Description
I am upgrading Chakra v2 to v3. Major upgrade!
My changes:
In v3, Chakra renamed many components and props. Therefore, there was a lot of renaming of components and props all across the app. In v3, Chakra also moved from closed components to open, compound components. Also, the structure of a lot of components just changed as well. Thus, I needed to update the JSX in a lot of places. Frequently, this required me to slightly update the logic of components, too.
sx was deprecated and replaced with css.
Referencing colors by their css variable name changed slightly.
Eg. var(--stacks-colors-borderPrimary) has become var(--stacks-colors-border-primary)
Due to Chakra deprecating Cacheprovider and the cookieSSRManager in v3, we need a new way of making sure what SSR generates matches what the client generates. We can do is by removing all uses of useColorMode and useColorModeValue, and no longer using these client side hooks moving forward. These hooks cause theme mistmaches between the server and client because they can only run on the client. On the server, the use of useTheme always returns undefined which causes the client side hooks to always return the dark theme color.
Existing bugs that were fixed as part of this PR:
Code quality improvements:
Testing Plan:
We have snapshot tests, but we do not have visual regression tests. In order to use those, we would need to investigate the options and do work to set that up for the project.
Considering that adding additional UI testing will take more time, and it's unclear if it will effectively catch UI regressions, I think the best we can do here is do manual testing for UI regressions. We should have a 1 hr. meeting where we go through the explorer and note any areas where there are or maybe regressions.
Things to check:
List of explorer pages:
Home page - http://localhost:3000/?chain=mainnet
Blocks page - http://localhost:3000/blocks?chain=mainnet
Block id page -
BTC block id page -
Tokens page - http://localhost:3000/tokens?chain=mainnet
Token page - http://localhost:3000/token/SM3VDXK3WZZSA84XXFKAFAF15NNZX32CTSG82JFQ4.sbtc-token?chain=mainnet (1 example)
Transactions page - http://localhost:3000/transactions?chain=mainnet
Transaction coinbase id page -
Transaction transfer id page - http://localhost:3000/txid/0x3b5c7aba50044a43ed577eff28027afa6c221e8c79e8e6c01f38752313b602e9?chain=mainnet (1 example)
Signers page - http://localhost:3000/signers?chain=mainnet
Signer id page - http://localhost:3000/signer/0x03b42ff50ea79b0dcee6a8e90610fb9f3cd00ce29769cc278dee2e446ab105722a?chain=mainnet (1 example)
Sandbox Deploy - http://localhost:3000/sandbox/deploy?chain=mainnet
Sandbox Faucet page -
Sandbox Contract Call -
Search page - http://localhost:3000/search?chain=mainnet&fromAddress=andre.btc&startTime=1735689600&endTime=1735862399 (1 example)
Light and dark mode.
Desktop vs mobile.
Do all the controls from Chakra UI behave the same?
How to handle errors and logging:
Issue ticket number and link
#1897
Checklist:
Screenshots (if appropriate):