Conversation
…ger be required when using clean TSV files
Contributor
Author
|
This will likely be built upon later on when we tackle event-replay perf. Leaving this PR open as draft for now. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the temporary pg table used during event-replay. This was originally in place to handle tsv files that contains 1) duplicate events, and 2) out of order events.
Now that we no longer support live appending to tsv files (only direct exports), we should no longer be dealing with these types of "dirty" tsv files.
This should be a performance improvement now that postgres no longer has to serve reads from the temp table while also writing events during ingestion.