Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2B2UI-991 - Data Request Manager: Button/trigger to reload the query… #505

Conversation

marcdanie
Copy link
Collaborator

… in query builder from the plugin

marc-danie and others added 3 commits March 10, 2025 15:40
… in query builder from the plugin - Merged changes from 1.8.2 branch
@marcdanie marcdanie requested a review from hackerceo March 14, 2025 17:02
… in query builder from the plugin - Added parameter to specify tab to show when reloading a query and code cleanup for reloadQuerySaga
Copy link
Member

@hackerceo hackerceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a cleaner implementation to just directly call i2b2.layout.selectTab() directly from the plugin rather than adding a side effect and complicating the doLoadQuery() function.

… in query builder from the plugin - Moved the call to switch to the find Patients to reloadQuerySaga.js
@marcdanie
Copy link
Collaborator Author

I went ahead and made the change to directly call i2b2.layout.selectTab from the plugin. Thanks!

marc-danie added 2 commits March 18, 2025 14:38
…uest_Manager_Trigger_to_reload_the_query_from_the_plugin

# Conflicts:
#	plugins/edu/harvard/catalyst/data-request-manager/build/asset-manifest.json
#	plugins/edu/harvard/catalyst/data-request-manager/build/index.html
#	plugins/edu/harvard/catalyst/data-request-manager/build/static/js/main.fdc838f5.js.LICENSE.txt
… in query builder from the plugin - Merged changes from 1.8.2
@marcdanie marcdanie merged commit 0212225 into v1.8.2 Mar 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants