Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/genral expect function using closure #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/genral expect function using closure #21

wants to merge 3 commits into from

Conversation

patrickmarschallek
Copy link

it gives the user of the frisby framework more power to use custom assertions.

@verdverm
Copy link
Member

verdverm commented Jun 4, 2017

This seems to include the AddFile change you submitted as well, I'm going to cherry pick the Expect Function and change the name of your AddFile to AddFileByKey. I may have broken code of others by not doing so.

verdverm added a commit that referenced this pull request Jun 4, 2017
 Cherry picked from #21
@verdverm
Copy link
Member

verdverm commented Jun 4, 2017

b165562

and

e6eb3c8

@verdverm
Copy link
Member

verdverm commented Jun 4, 2017

I will close this if it looks like I've captured your changes in the other commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants