Skip to content

Conversation

@DeedleFake
Copy link

Here's RenderTo() in it's own pull request. I deleted the really old fork I had, but I kept a local backup.

As part of implementing RenderTo() I also added several places in the rendering methods that can cause errors to be returned, specifically when writing to the io.Writer. With just a bytes.Buffer it's not a problem to not check for errors as the documentation says it's always nil, but with an unknown io.Writer I thought it might be better to check.

I also accidentally ran gofmt, so the diff wound up being quite a bit longer than the actual changes to the code, which were fairly minor.

@hoisie
Copy link
Owner

hoisie commented Apr 8, 2013

It's very hard for me to see the actual diff because of all the whitespace changes. Can you just run 'make format', and send a new pull request? make format just runs:

gofmt -s -tabs=false -tabwidth=4 mustache.go
gofmt -s -tabs=false -tabwidth=4 mustache_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants