Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor _showSearchFocus #111

Open
wants to merge 2 commits into
base: hokuto
Choose a base branch
from
Open

refactor _showSearchFocus #111

wants to merge 2 commits into from
+31 −17

Conversation

MasayukiYAMA
Copy link
Member

@MasayukiYAMA MasayukiYAMA commented Jul 4, 2024 •
edited
Loading

サマリ

コンテンツ内ジャンプリンクの実装で、「zefyr内の検索処理」と同じ機構を使われており、
密結合な部分があったので、処理を分割した

具体的にしたこと

  • onChangeSearchFocusTop を scrollToMatchStream にrename
  • コンテンツ内ジャンプリンクのための処理では setState(() { _searchFocus = focus; }); を実行しないように変更
  • _showSearchFocus のうち、「スクロールに関する処理」をscrollToSelection(TextSelection ) に変更

@MasayukiYAMA MasayukiYAMA requested review from turara and son July 11, 2024 02:54
son
son approved these changes Jul 17, 2024
View reviewed changes
Copy link

@son son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@son son son approved these changes

@turara turara Awaiting requested review from turara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasayukiYAMA @son