Switch to Hyperdb #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
Feb 7, 2025
index.js
Outdated
| @@ -105,6 +114,34 @@ class Autopass extends ReadyResource { | |||
| this.pairing = null | |||
| this.replicate = opts.replicate !== false | |||
| this.debug = !!opts.key | |||
| // Register handlers for commands | |||
| this.router.add('@autopass-namespace/removeWriter', async (data, context) => { | |||
There was a problem hiding this comment.
the -namespace is redundant, just @autopass/remove-writer
mafintosh
reviewed
Feb 7, 2025
index.js
Outdated
| // Register handlers for commands | ||
| this.router.add('@autopass-namespace/removeWriter', async (data, context) => { | ||
| await context.base.removeWriter(data.key) | ||
| return { success: true } |
mafintosh
reviewed
Feb 7, 2025
index.js
Outdated
|
|
||
| this.router.add('@autopass-namespace/put', async (data, context) => { | ||
| await context.view.insert('@autopass-namespace/autopass', data) | ||
| await context.view.flush() |
There was a problem hiding this comment.
move the flush to the apply call post router dispatch, same for all flushes
mafintosh
reviewed
Feb 7, 2025
mafintosh
reviewed
Feb 7, 2025
index.js
Outdated
| if (node === null) return null | ||
| return node.value | ||
| const queryStreams = await this.base.view.get('@autopass-namespace/autopass', { key }) | ||
| const data = await queryStreams |
There was a problem hiding this comment.
this makes no sense, just data = await this....get(...)
mafintosh
reviewed
Feb 7, 2025
schema.js
Outdated
|
|
||
| // SCHEMA CREATION START // | ||
| const schemaTemplate = Hyperschema.from('./spec/schema') | ||
| const templateNamespace = schemaTemplate.namespace('autopass-namespace') |
There was a problem hiding this comment.
name this autopass vs template...
There was a problem hiding this comment.
What do you mean by this?
mafintosh
reviewed
Feb 7, 2025
index.js
Outdated
| @@ -173,6 +165,7 @@ class Autopass extends ReadyResource { | |||
| for (const node of nodes) { | |||
| await this.router.dispatch(node.value, { view, base }) | |||
| } | |||
| view.flush() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.