feat: allow control over uploading to peers#499
Draft
gmaclennan wants to merge 1 commit intoholepunchto:mainfrom
Draft
feat: allow control over uploading to peers#499gmaclennan wants to merge 1 commit intoholepunchto:mainfrom
gmaclennan wants to merge 1 commit intoholepunchto:mainfrom
Conversation
Partial fix to holepunchto#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix to #305
Creating as a draft for initial feedback on proof-of-concept.
This is useful because you may want to download data from a peer, but not allow uploads to a peer.
@mafintosh would one of your team be able to look at this? I'm a bit out of my depth with the inner workings of the replicator code.