Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date fixes for some US states #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erluti
Copy link

@erluti erluti commented Sep 12, 2024

Fixes for:

Mardi Gras in AL

Confederate Memorial Day in AL (4th monday)

Good Friday in PA

Arbor Day in NE (change calculation to Last Friday)

Election Day in LA

@@ -74,7 +74,7 @@ months:
function: easter(year)
function_modifier: -47
- name: Mardi Gras Day
regions: [us_la]
regions: [us_al, us_la]
Copy link
Author

@erluti erluti Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mardi Gras Day (only in Baldwin and Mobile Counties) (Personal Leave Day will be granted for all other counties.)

https://admincode.legislature.state.al.us/administrative-code/670-X-12-.01

@@ -83,7 +83,7 @@ months:
function_modifier: -2
type: informal
- name: Good Friday # public holiday in the following states
regions: [us_ct, us_de, us_gu, us_hi, us_in, us_ky, us_la, us_nj, us_nc, us_nd, us_pr, us_tn]
regions: [us_ct, us_de, us_gu, us_hi, us_in, us_ky, us_la, us_nj, us_nc, us_nd, us_pa, us_pr, us_tn]
Copy link
Author

@erluti erluti Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +163 to +166
- name: Confederate Memorial Day # 4th Monday in April
regions: [us_al]
week: 4
wday: 1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +174 to +177
- name: Arbor Day
regions: [us_ne]
mday: 28
week: -1
wday: 5
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +276 to +278
- name: Election Day # even years only
regions: [us_la]
function: even_year_election_day(year)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Election Day | Tuesday, after the first Monday in November, every two years

https://www.lpsc.louisiana.gov/DNC_Holidays

@erluti erluti marked this pull request as ready for review September 13, 2024 14:13
@erluti
Copy link
Author

erluti commented Sep 19, 2024

@ppeble could you review this and consider merging? Let me know if you have any feedback

Copy link

@wleeper wleeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well documented change

@erluti
Copy link
Author

erluti commented Oct 9, 2024

@ppeble Election day is coming up and this change will help in LA. Do you know when you could review?

@erluti
Copy link
Author

erluti commented Oct 11, 2024

Election day is coming up and this change will help in LA.

Just realized this reads like some political spam, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants