Fix WS protocol for trycp client #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jost-s
approved these changes
Jun 13, 2024
crates/trycp_client/src/lib.rs
Outdated
| let pend2 = pend.clone(); | ||
| let recv_task = tokio::task::spawn(async move { | ||
| while let Some(Ok(msg)) = stream.next().await { | ||
| let msg = msg.into_data(); | ||
| let msg = match msg { | ||
| Message::Close(_) => { |
There was a problem hiding this comment.
Is it worth outputting the variant field value?
There was a problem hiding this comment.
Seems like a good idea, I'll be back here next week adding it if I don't do it now :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without Ping/Pong handling, the connection was being force closed by the TryCP server.
The close message has empty content which was giving me a very confusing EOF trying to deserialize from the empty vector into a response message.
Explicitly handling the WS protocol now and it's working much better