Prevent autover from failing when used alongside async frameworks

autover/version.py

@@ -117,7 +117,7 @@ def run_cmd(args, cwd=None):
                             cwd=cwd)
     output, error = (str(s.decode()).strip() for s in proc.communicate())
 
-    if proc.returncode != 0:
+    if proc.returncode != 0 or len(error) > 0:
         raise Exception(proc.returncode, error)
     return output
 

conda.recipe/meta.yaml

@@ -26,6 +26,7 @@ test:
   source_files:
     - tests
   commands:
+    - conda install -y -c conda-forge gunicorn uvicorn starlette
     - nosetests -vv --nologcapture
 
 about:

examples/PkgBundle/version.py

@@ -117,7 +117,7 @@ def run_cmd(args, cwd=None):
                             cwd=cwd)
     output, error = (str(s.decode()).strip() for s in proc.communicate())
 
-    if proc.returncode != 0:
+    if proc.returncode != 0 or len(error) > 0:
         raise Exception(proc.returncode, error)
     return output
 

examples/pkg_bundle/version.py

@@ -117,7 +117,7 @@ def run_cmd(args, cwd=None):
                             cwd=cwd)
     output, error = (str(s.decode()).strip() for s in proc.communicate())
 
-    if proc.returncode != 0:
+    if proc.returncode != 0 or len(error) > 0:
         raise Exception(proc.returncode, error)
     return output
 

tests/test_asgi_server.py

@@ -0,0 +1,24 @@
+import autover
+from starlette.applications import Starlette
+
+# A simple ASGI server application
+# that tries to make use of autover.
+#
+# Given that autover makes use of
+# subprocess.Popen and the program
+# workflow depends on that, there
+# were some corner cases where
+# autover would just crash if we
+# tried to get its __version__,
+# therefore crashing the whole
+# ASGI application.
+#
+# This test application is used
+# with Gunicorn in the unit tests
+# (testversion.py), just to check
+# if the ASGI application crashes
+# or not.
+
+_ = autover.__version__
+
+app = Starlette()

tests/testversion.py

@@ -1,7 +1,11 @@
 """
 Unit test for autover.Version
 """
+import os
 import unittest
+import subprocess
+import sys
+import time
 import pkg_resources._vendor.packaging.version as packaging_version
 from autover import Version
 
@@ -75,6 +79,7 @@ def pep440(version):
 
 
 class TestVersion(unittest.TestCase):
+    maxDiff=None
 
 
     def git_describe_check(self, describe_tests, index):
@@ -160,6 +165,32 @@ def test_git_describe_4(self):
     def test_git_describe_5(self):
         self.git_describe_check(describe_tests, 5)
 
+    #=======================================#
+    #  Compatibility with ASGI applications #
+    #=======================================#
+
+    def test_run_asgi_server(self):
+        """test_run_asgi_server (An ASGI app that uses autover and is launched with Gunicorn should not crash)"""
+        if sys.version[0] == "3":
+            serverfile_dir = os.path.abspath(os.path.join(__file__, os.pardir))
+            logfile_path = os.path.abspath(os.path.join(__file__, os.pardir, "stderr_gunicorn.log"))
+            subprocess.Popen(["gunicorn", "-D", "--log-level", "ERROR", 
+                              "--chdir", serverfile_dir,
+                              "-k", "uvicorn.workers.UvicornWorker", 
+                              "--error-logfile", logfile_path,
+                              "--bind", "unix:/tmp/gunicorn.sock", 
+                              "test_asgi_server:app"])
+            time.sleep(5)
+            with open(logfile_path, "r") as gunicorn_log_file:
+                stderr_log = gunicorn_log_file.read()
+
+            subprocess.Popen(["pkill", "-f", "gunicorn"])
+            time.sleep(5)
+            os.remove(logfile_path)
+        else:
+            stderr_log = ""
+        self.assertEqual(stderr_log, "")
+
 if __name__ == "__main__":
     import nose
     nose.runmodule()

tox.ini

@@ -3,8 +3,12 @@ envlist = py36,py27
 
 [testenv]
 passenv = GIT_VERSION
-deps = nose
-commands = nosetests -vv --nologcapture --with-doctest --with-coverage --cover-package=autover
+deps = 
+    nose 
+    gunicorn;python_version>"3.4"
+    uvicorn;python_version>"3.4"
+    starlette;python_version>"3.4"
+commands = nosetests -vv --nologcapture --with-doctest --with-coverage --cover-package=autover --ignore-files=test_asgi_server.py
 
 [testenv:lint_checks]
 deps = flake8