-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check stderr for subprocess call errors #67
Conversation
bed708e
to
c40fb5a
Compare
TODO
|
Co-authored-by: James A. Bednar <[email protected]>
I'm happy to have the actual code change from this PR or #59, but the updates to the tests rely on a slew of other libraries that aren't appropriate to include in the autover codebase, even as optional tests. If it's possible to boil those tests down to a small amount of standard Python, it would be great to include them, but otherwise I'd say the probability that these tests will cause maintenance issues for us over time is much higher than the probability that they will catch actual errors. I'd strongly favor moving towards a design like #66 where released versions are no longer ever calling any subprocesses at all, at which point no such tests should be necessary in any case. |
I agree and I've updated the PR to just include just the fix (they are still in the history and shown to be passing, thanks @julioasoto!). As you say, once #66 is working this code path should be mostly moot (for release users at least). @jbednar Think this simplified PR can now be merged? |
This PR simply moves #59 from a fork to this repo so that I can attempt to fix the tests.