-
-
Notifications
You must be signed in to change notification settings - Fork 407
feat: Support Narwhals #6567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Support Narwhals #6567
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6567 +/- ##
==========================================
- Coverage 88.82% 88.78% -0.04%
==========================================
Files 326 328 +2
Lines 69449 70060 +611
==========================================
+ Hits 61685 62200 +515
- Misses 7764 7860 +96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -645,7 +645,7 @@ def select(self, selection_expr=None, selection_specs=None, **selection): | |||
return self | |||
|
|||
# Handle selection dim expression | |||
if selection_expr is not None: | |||
if selection_expr is not None and selection_expr.ops: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also make something like hv.Dataset(df_pandas).select(selection_expr=hv.dim('a'))
fail
Still very much draft... A lot of the logic is currently copied/pasted from the
PandasInterface
.