refactor: Use ImageStack as an self.p.element_type if AggState.has_by
#6631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6631 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 328 328
Lines 69990 69985 -5
=======================================
- Hits 62219 62215 -4
+ Misses 7771 7770 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoxbro
force-pushed
the
refactor_element_type
branch
from
af3c26a to
4fd74be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #6628 this should now be possible. I don't want to enable it for the next release, 1.21.0, as there could be consequences I haven't considered.