-
-
Notifications
You must be signed in to change notification settings - Fork 22
Share image #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahuang11
wants to merge
16
commits into
main
Choose a base branch
from
share_image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Share image #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1597 +/- ##
==========================================
+ Coverage 66.69% 66.97% +0.27%
==========================================
Files 150 150
Lines 24656 24770 +114
==========================================
+ Hits 16445 16590 +145
+ Misses 8211 8180 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes because I wanted to remove VegaLiteSpecUpdate, which had a bunch of complex logic for insertion, and follow what Claude does of search and replace strings. The other variation, RetrySpec (add, insert, delete lines, had issues where that LLMs have a tendency to dynamically hallucinate line numbers while inserting.
Adds intermediate view before applying interaction polish, so users can see v1 before v2 tweaks chart and fixes issues.
Show image to LLM for polish and revise so it can actually see what it's editing.
Improved data schema, e.g. explicitly mentioning what are dimensions and measures, the data shape type, and migrating head & tail to the corresponding stats column to prevent duplicate tokens