Skip to content

Conversation

@thuydotm
Copy link
Collaborator

@thuydotm thuydotm commented Aug 25, 2022

Changes addressed in this PR:

  • split catalog to different files to test IntakeSource and IntakeSQLSource separately
  • move tests for FileSource to a new file
  • add tests to JSONSource
  • add tests to JoinedSource
  • move common testing logics to a utils file
  • test Source.from_spec when loading from source in state.sources

Bug fixes:

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #309 (8c50ba6) into master (f94ee65) will increase coverage by 0.53%.
The diff coverage is 98.42%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   66.26%   66.80%   +0.53%     
==========================================
  Files          59       62       +3     
  Lines        6178     6250      +72     
==========================================
+ Hits         4094     4175      +81     
+ Misses       2084     2075       -9     
Impacted Files Coverage Δ
lumen/tests/sources/test_intake.py 92.68% <86.95%> (-7.32%) ⬇️
lumen/tests/conftest.py 97.54% <92.85%> (-0.63%) ⬇️
lumen/sources/base.py 66.00% <100.00%> (+3.34%) ⬆️
lumen/tests/sources/test_base.py 100.00% <100.00%> (+0.94%) ⬆️
lumen/tests/sources/test_derived.py 100.00% <100.00%> (ø)
lumen/tests/sources/test_file.py 100.00% <100.00%> (ø)
lumen/tests/sources/test_intake_sql.py 100.00% <100.00%> (ø)
lumen/tests/sources/test_json.py 100.00% <100.00%> (ø)
lumen/tests/sources/utils.py 100.00% <100.00%> (ø)
lumen/sources/intake_sql.py 83.78% <0.00%> (-5.41%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thuydotm thuydotm changed the title Add more Sources tests (WIP) Add more Sources tests Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants