Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ParamOverrides #1041

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Validate ParamOverrides #1041

wants to merge 1 commit into from

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 7, 2025

I just chatted with @hoxbro and told him I had this in my stash. Totally untested at this stage. Wildly simpler than the alternative implementation attempted in #92, which I think focused quite a bit on getting things perfectly right with Dynamic Parameters.

  • Add tests
  • Run HoloViews' test suite with Param's code checkout from this PR
  • Warn first when the validation fails, letting users know in the future this will raise an error

Fixes #85

@maximlt maximlt marked this pull request as draft March 7, 2025 13:25
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (90303ac) to head (1da4ee7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   87.45%   87.46%           
=======================================
  Files           9        9           
  Lines        4959     4962    +3     
=======================================
+ Hits         4337     4340    +3     
  Misses        622      622           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParamOverrides seem to be broken
1 participant