Do not remove nested_refs when updating another ref #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 87.45% 87.47% +0.02%
==========================================
Files 9 9
Lines 4959 4959
==========================================
+ Hits 4337 4338 +1
+ Misses 622 621 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maximlt
approved these changes
Jun 11, 2025
maximlt
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally refs are resolved by watchers. Whenever a ref is updated we currently remove all existing ref watchers and then re-add them. Unfortunately there was an oversight which meant that when a ref is updated the existing nested refs are not correctly restored. This fixes this ensuring that we resolve the nested refs correctly.