Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.6 #203

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Drop support for EOL Python 2.6 #203

merged 1 commit into from
Jan 24, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 28, 2017

Fixes #175.

@coveralls
Copy link

coveralls commented Oct 28, 2017

Coverage Status

Coverage increased (+0.05%) to 75.426% when pulling 72d858b on hugovk:rm-2.6 into 64c8f7c on ioam:master.

@ceball
Copy link
Member

ceball commented Nov 9, 2017

Thanks for following up comments with code :) The delay in responding is down to PR #202, opened just two days before this one, which ought to be merged first. Once that's finished, we'll move onto this...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.111% when pulling a893cce on hugovk:rm-2.6 into 787732a on ioam:master.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 9, 2018

PR #202 is now merged, I've rebased this on master.

@ceball
Copy link
Member

ceball commented Jan 24, 2018

Thanks for updating your PR. I'd be happy for this to be merged, and I think it's ok for the next release of param not to support 2.6.

(@jbednar, ok to merge, or do you see any problems?)

@jbednar
Copy link
Member

jbednar commented Jan 24, 2018

Looks good; happy to see the end of 2.6!

@jbednar jbednar merged commit 59f2deb into holoviz:master Jan 24, 2018
@hugovk hugovk deleted the rm-2.6 branch January 24, 2018 15:27
ceball added a commit that referenced this pull request Apr 3, 2018
…nce #203); be explicit about using setuptools (pip always uses setuptools, even if you don't import setuptools).
@ceball ceball mentioned this pull request Apr 3, 2018
ceball added a commit that referenced this pull request Apr 3, 2018
…nce #203); be explicit about using setuptools (pip always uses setuptools, even if you don't import setuptools).
ceball added a commit that referenced this pull request Apr 3, 2018
* Declare that only python 2.7+ is supported (true since #203)
* Be explicit about using setuptools (pip always uses setuptools, even if you don't import setuptools).

Python.org python 2.7.0-2.7.8 and 3.0-3.3 users will now need to install pip/setuptools before installing param.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants