Update sip.py #34
Update sip.py #34
Conversation
Do not use FROM header as response target address
|
You are absolutely right about the FROM header in the RFC, so this definitely needs updating. I do think it is still valid, and helpful, to use the FROM header URI to identify the endpoint however. I think it would be better to leave the caller_endpoint logic as is and add a separate field to expose the contact header value specifically. I think that should allow us to avoid some migration issues with the HA integration, but still put us in compliance with the spec, and hopefully work for the implementation you are using as well. |
|
Yes! Please approve, solves my problem where I am forced to use the default port 5060 instead of my own port. |
|
@Schlepptop @phavel Would it be possible for you to test with the changes in #40 to see if that solves your issue? |
|
Addressed in #40 |
|
@jaminh Thank you for the edit! I will be able to test it in about a month. |
|
Tested and works, fixed, great and thanks! |
3 participants
Do not use FROM header to find response target address
Fixes #33