Add tag to To header if missing #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Add tag in TO header if not present
As is the tag parameter will get added outside the angle brackets when a header value has a description.
Add parsing of parameters and headers in SIP URIs in the SipEndpoint class.
Collaborator
Author
|
Based on https://datatracker.ietf.org/doc/html/rfc3261#section-20.10 and example messages I have seen in testing it appears the tag parameter is getting added after the ">", so the parsing and header generation logic I have here isn't quite right. |
Contact, To, and From headers may contain header parameters in addition to the SIP URI containing URI parameters.
Collaborator
Author
|
My header parsing was not accounting for the fact that Contact, To, and From headers may contain header parameters in addition to the URI parameters of the SIP URI. The tag parameter specified in RFC 3261 is a header parameter not a URI parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tag to To header if missing per https://datatracker.ietf.org/doc/html/rfc3261#section-8.2.6.2.
#35