Skip to content

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Dec 1, 2025

Summary

We had some strings not used anymore in the project, mostly because I've removed the onboarding but also some others.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds and there were no stand outs for me, so I'm assuming it's OK - I didn't search for every string manually.

As previously mentioned some of these changes do not need the use_new_onboarding branch, please be mindful of that in the future (getting very big).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants