Skip to content

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Dec 1, 2025

Summary

hiltViewModel extension has been moved to another package this PR use the new one.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

@jpelgrom
Copy link
Member

jpelgrom commented Dec 1, 2025

Do all these PRs need to merge into feature/use_new_onboarding? That branch is becoming quite big.

@TimoPtr
Copy link
Member Author

TimoPtr commented Dec 1, 2025

Do all these PRs need to merge into feature/use_new_onboarding? That branch is becoming quite big.

This or we merge the use_new_onboarding on main then all of these other branches.
Or we can wait until I have most of block PR's ready.

@jpelgrom
Copy link
Member

jpelgrom commented Dec 1, 2025

This or we merge the use_new_onboarding on main

That depends on your confidence :) But some of these changes, like this PR and part of the string cleanup, don't really need feature/use_new_onboarding.

@TimoPtr
Copy link
Member Author

TimoPtr commented Dec 1, 2025

This or we merge the use_new_onboarding on main

That depends on your confidence :) But some of these changes, like this PR and part of the string cleanup, don't really need feature/use_new_onboarding.

Some of the strings yes but most of them are from the onboarding so they actually need the other branch.

In terms of my confidence I hope to have something by the end of the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants